Interactive example for Intl.Locale #1394
Conversation
| @@ -0,0 +1,12 @@ | |||
| <pre> | |||
| <code id="static-js">const korean = new Intl.Locale("ko", {script: "Kore", region: "KR", hourCycle: "h24", calendar: "gregory"}); | |||
There was a problem hiding this comment.
Rather than have it on one line it would be easier to read like:
const korean = new Intl.Locale("ko", {
script: "Kore", region: "KR", hourCycle: "h24", calendar: "gregory"
});There was a problem hiding this comment.
Also here and elsewhere, single quotes for strings is our style.
(although note: use double for the expected output strings)
| @@ -0,0 +1,12 @@ | |||
| <pre> | |||
| <code id="static-js">const korean = new Intl.Locale("ko", {script: "Kore", region: "KR", hourCycle: "h24", calendar: "gregory"}); | |||
| const japan = new Intl.Locale("ja-Jpan-JP-u-ca-japanese-hc-h12") | |||
There was a problem hiding this comment.
Here and elsewhere, end the line with a semicolon.
There was a problem hiding this comment.
Also we should be consistent with variable names: so either:
"japan" and "korea"
or
"japanese" and "korean"
| @@ -0,0 +1,12 @@ | |||
| <pre> | |||
| <code id="static-js">const korean = new Intl.Locale("ko", {script: "Kore", region: "KR", hourCycle: "h24", calendar: "gregory"}); | |||
| const japan = new Intl.Locale("ja-Jpan-JP-u-ca-japanese-hc-h12") | |||
There was a problem hiding this comment.
Also a blank space before this line (to separate the two declarations) would help readability I think.
| // expected output: "ko-Kore-KR" | ||
|
|
||
| console.log(japan.baseName) | ||
| // expected output: "ja-Jpan-JP" |
There was a problem hiding this comment.
Since my above comments make the example longer, why not compress this bit as you do below, with something like:
console.log(korean.baseName, japan.baseName)
// expected output: "ko-Kore-KR" "ja-Jpan-JP"| <pre> | ||
| <code id="static-js">const korean = new Intl.Locale("ko", {script: "Kore", region: "KR", hourCycle: "h24", calendar: "gregory"}); | ||
| const japan = new Intl.Locale("ja-Jpan-JP-u-ca-japanese-hc-h12") | ||
| console.log(korean.baseName) |
There was a problem hiding this comment.
Also a blank line before this (after the 2 declarations) would help readability.
|
Requested changes made! :D |
|
Thanks @wbamberg! My pleasure :D |
Added an interactive example for Intl.Locale. Demonstrates several of Locale's properties.
Example renders correctly and outputs correct values.
Part of an MDN documentation effort for Intl.Locale on behalf of ECMA 402.
Thanks!