use input event listener for word counter example closes #51 #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ralyodio
approved these changes
Oct 19, 2024
|
Thanks a lot for opening this one. BTW, we have the following in content that also needs to be updated: https://github.com/mdn/content/blob/ca1fc680cd7c7c04bed18d8ab1fa3988bf7e972e/files/en-us/web/api/element/attachshadow/index.md?plain=1#L163-L166 |
bsmth
added
the
needs content update
bsmth
approved these changes
Oct 28, 2024
MiB-1
added a commit
to MiB-1/content
that referenced
this pull request
Oct 28, 2024
Updating the content according to the example mdn/web-components-examples#80
|
thanks @bsmth , here is the link for updating the content repo: |
Josh-Cena
reviewed
Oct 28, 2024
bsmth
pushed a commit
to mdn/content
that referenced
this pull request
Oct 29, 2024
* Update content according to the example Updating the content according to the example mdn/web-components-examples#80 * fix lint * Update files/en-us/web/api/element/attachshadow/index.md --------- Co-authored-by: Joshua Chen <[email protected]>
thanks a lot, looking forward to contribute more. may I know when this be PR will get merge? |
|
Merging now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Word counter example
As mentioned in the issue instead of using setInterval we can use input event listener.
Closes #51