feat(core): remove beacon id and use new duration table #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously used a randomly generated ID from the tracker side to help link
loadandunloadevents. This method was privacy-preserving as it could not identify a single user (a simple refresh or page navigation changes the ID), however, it still felt shaky being an identifier of some sort.This creates a new
durationtable which will send duplicated events with time spent on page data on theunloadevent, removing the need for an ID to link these events together. For now, storage usage is close to double than before due to duplicate data, however, #7 will eliminate that downside upon implementation.As queries had to be completely rewritten to accommodate the new table, this PR also introduces full testing for all the stats queries which were previously not present.