Repository navigation
Upgrade dependencies and build tooling - #10
Open
mfx-jgoetzinger wants to merge 1 commit into
Open
mfx-jgoetzinger wants to merge 1 commit into
mfx-jgoetzinger wants to merge 1 commit into
Conversation
mfx-jgoetzinger
requested review from
stefanhorning
and
a lite review from Copilot
September 2, 2026 13:22
There was a problem hiding this comment.
🟡 Changes recommended
The new Proxy provisioning approach can unintentionally alter Proxy feature-detection/semantics across bundled dependencies and should be tightened to avoid runtime regressions.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Updates the project’s JavaScript/TypeScript toolchain and runtime dependencies to modern versions, refreshes the ES5 bundling pipeline (Webpack 5 + Babel), and aligns CI to the new Node/tooling expectations.
Changes:
- Upgrade runtime dependencies (e.g., core-js, lodash, superagent) and dev tooling (TypeScript, webpack, loaders).
- Modernize the ES5 webpack build (Webpack 5 rules, output environment targeting, add Proxy provisioning for legacy runtimes).
- Update generated
dist/artifacts and tweak CLI + CI workflow accordingly.
File summaries
| File | Description |
|---|---|
webpack.config.js |
Migrates config to Webpack 5, adds ES5 output constraints, Babel processing, and Proxy provisioning. |
src/support/callable-proxy.js |
Adds a callable Proxy fallback intended for environments without native Proxy. |
package.json |
Bumps runtime/dev dependencies and sets Node engine requirement. |
dist/chinchilla/watcher.js |
Regenerated output (TS/lodash callsite wrapping changes). |
dist/chinchilla/tools.js |
Regenerated output (exports + lodash callsite wrapping changes). |
dist/chinchilla/tools.d.ts |
Regenerated typings (static readonly -> getters). |
dist/chinchilla/subject.js |
Regenerated output (lodash callsite wrapping changes). |
dist/chinchilla/subject.d.ts |
Regenerated typings (readonly -> getters). |
dist/chinchilla/result.js |
Regenerated output (exports + lodash callsite wrapping changes). |
dist/chinchilla/result.d.ts |
Regenerated typings (readonly -> getter). |
dist/chinchilla/extractor.js |
Regenerated output (lodash callsite wrapping changes). |
dist/chinchilla/context.js |
Regenerated output (exports + lodash callsite wrapping changes). |
dist/chinchilla/context.d.ts |
Regenerated typings (readonly -> getters). |
dist/chinchilla/config.js |
Regenerated output (lodash callsite wrapping changes + minor comment). |
dist/chinchilla/config.d.ts |
Regenerated typings (static readonly -> getter). |
dist/chinchilla/cache.js |
Regenerated output (exports + lodash callsite wrapping changes). |
dist/chinchilla/cache.d.ts |
Regenerated typings (static readonly -> getter). |
dist/chinchilla/association.js |
Regenerated output (exports + lodash callsite wrapping changes). |
dist/chinchilla/association.d.ts |
Regenerated typings (readonly -> getter). |
dist/chinchilla/action.js |
Regenerated output (lodash callsite wrapping changes). |
dist/chinchilla.js |
Adjusted exports wiring + lodash callsite wrapping changes. |
dist/chinchilla.d.ts |
Typing tweak for chch call signature. |
bin/cli.js |
Removes async-repl stubber usage. |
.github/workflows/javascript.yml |
Updates CI Node version and uses frozen lockfile install. |
Review details
- Files reviewed: 4/26 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+1
to
+14
| 'use strict' | ||
|
|
||
| module.exports = function CallableProxy(target, handler) { | ||
| var proxy = function () { | ||
| return handler.apply(target, this, Array.prototype.slice.call(arguments)) | ||
| } | ||
|
|
||
| Object.keys(target).forEach(function (key) { | ||
| proxy[key] = target[key] | ||
| }) | ||
| proxy.prototype = target.prototype | ||
|
|
||
| return proxy | ||
| } |
Comment on lines
+43
to
+46
| plugins: [ | ||
| new webpack.ProvidePlugin({ | ||
| Proxy: path.resolve(__dirname, 'src/support/callable-proxy.js') | ||
| }) |
stefanhorning
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.