Conversation
The bundled GetGitRevisionDescription.cmake module sets HEAD_HASH to the
refspec string ("refs/heads/<branch>") when .git/refs/heads/<branch> does
not exist as a loose ref (i.e. refs are packed), causing the binary to
print "ApproxMC SHA1: refs/heads/develop" instead of the actual hash.
Replace the call with a direct `git rev-parse HEAD` invocation, which
resolves the hash correctly regardless of pack state.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
gcc's spec uses linker-script wrappers libgcc_s_asneeded.so / libatomic_asneeded.so that have no static counterpart. CMake captures them in CMAKE_<LANG>_IMPLICIT_LINK_LIBRARIES and propagates them to consumers when a static archive in the link chain has C source. Under -static the linker then fails with "cannot find -lgcc_s_asneeded". Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
flake.lock had grown to ~20 nodes with cadical duplicated 5x, cadiback 3x, and cryptominisat/sbva/evalmaxsat/treedecomp 2x each: approxmc, its arjun input, and the cryptominisat(s) each independently declared the same dependencies, so they got separate nodes free to drift apart. Declare cadiback once as the single anchor (not used by approxmc directly, but needed to dedup the tree) and route every transitive copy through follows: - cryptominisat's cadiback follows ours - arjun's cadiback/cadical/cryptominisat/sbva/evalmaxsat/treedecomp all follow ours Result: 8 input nodes, exactly one revision of each dependency. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.