Expose LaurentPolyGen as mode 13#114
Open
msoos wants to merge 10 commits into
Open
Conversation
CMS now emits a per-step nesting depth on each [simp-stats] line. Steps emitted inside an outer wrapper (e.g. must-renumber dispatched from oracle-vivif-veryfast) get depth>=1 and would double-count if summed alongside their depth=0 parent. - get_data_ganak.py: extend _SIMP_STATS_RE to capture the optional "depth N" suffix; key pending BEFOREs on (name, depth) with LIFO popping so same-name nesting matches correctly; add depth to the record/CSV/sqlite preproc schema (defaulting to 0 for older logs). - create_graphs_ganak.py: add "AND depth = 0" to every preproc chart aggregator so totals reflect only top-level steps. Existence-check COUNT queries left alone since they don't aggregate. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Backbone-simpl is invisible on the volume-based cumulative chart because its only contribution is via unit propagation (delta_free_vars from units) which is dwarfed by occ-bve's BVE elimination. Plotting cumulative delta_units separately makes backbone-simpl's ~44% share of unit-finding visible at its pipeline position. Also: accept .out_arjun files in get_data_ganak.py; switch only_dirs to the latest run (1635700-0). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Cumulative chart was unusably tall (52cm x ~40cm) and the pie chart's labels were too small to read once scaled down inside a beamer slide. Reduce both figure sizes and bump pie-chart font sizes; move the cumulative-chart legend to bottom right where it doesn't sit on top of the curves.
Add Laurent polynomial counting (multivariate Laurent polynomials over the rationals, allowing negative exponents) as --mode 13, wiring up the FieldGen construction and result output. Document usage with a worked example in the README and add a lit test. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
zlib.net DNS resolution fails in CI; download the identical zlib-1.3.1 tarball from the madler/zlib GitHub release instead. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LaurentPolyGenfield as--mode 13(multivariate Laurent polynomials over the rationals, allowing negative exponents), wiring upFieldGenconstruction and result output (c s exact laurent ...).tests/cnf-files/mode13.cnf) covering negative exponents.Test plan
cmake --build build --target ganak-binsucceedslit tests/cnf-files/— all 21 tests pass, including the newmode13.cnf--mode 13 --npolyvars 2produces the documented Laurent polynomial output🤖 Generated with Claude Code