Skip to content

feat(js client): add retry mechanism - #353

Merged
GuillaumeDecMeetsMore merged 5 commits into
masterfrom
guillaume/feat/js-client-add-retry-mechanism
Jul 3, 2025
Merged

feat(js client): add retry mechanism#353
GuillaumeDecMeetsMore merged 5 commits into
masterfrom
guillaume/feat/js-client-add-retry-mechanism

Conversation

@GuillaumeDecMeetsMore

@GuillaumeDecMeetsMore GuillaumeDecMeetsMore commented Jul 3, 2025

Copy link
Copy Markdown
Collaborator

Changed

  • In JS client, add a retry mechanism for GET, PUT and DELETE requests (idempotent requests)
    • Enabled by default
    • Uses axios-retry
    • For network errors. and for 5xx errors
    • 3 retries

@GuillaumeDecMeetsMore GuillaumeDecMeetsMore self-assigned this Jul 3, 2025
@GuillaumeDecMeetsMore
GuillaumeDecMeetsMore marked this pull request as ready for review July 3, 2025 02:33
Comment thread clients/javascript/lib/baseClient.ts Outdated
*/
export type RetryConfig = {
/**
* Whether to enable retry mechanism (default: true)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nit] you can use @default in JSDoc

(there's basically no benefit, it just highlights differently)

@GuillaumeDecMeetsMore
GuillaumeDecMeetsMore merged commit 2fae711 into master Jul 3, 2025
6 of 8 checks passed
@GuillaumeDecMeetsMore
GuillaumeDecMeetsMore deleted the guillaume/feat/js-client-add-retry-mechanism branch July 3, 2025 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants