Skip to content

MD5 hashing is used for fingerprinting #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Letme merged 5 commits into from
Feb 13, 2026
Merged

MD5 hashing is used for fingerprinting #187

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c3ba7b2
MD5 hashing is used for fingerprinting
Letme Feb 13, 2026
9b90028
Use the custom function for hash to ensure support for python 3.8
Letme Feb 13, 2026
714d9bb
Fixing the style
Letme Feb 13, 2026
e2d4693
Surpress the warning because we intentionally omit the argument for p…
Letme Feb 13, 2026
b095c8b
Stylecheck fix
Letme Feb 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/mlx/warnings/code_quality.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import hashlib
from pathlib import Path
import sys


class Finding:
Expand Down Expand Up @@ -32,9 +33,9 @@ def fingerprint(self):
4. Step 3 is repeated until a unique hash is obtained.
"""
hashable_string = f"{self.severity}{self.path}{self.description}"
new_hash = hashlib.md5(str(hashable_string).encode("utf-8")).hexdigest()
new_hash = self._md5_hash(str(hashable_string).encode("utf-8"))
while new_hash in self.fingerprints and self.fingerprints[new_hash] != self:
new_hash = hashlib.md5(f"{hashable_string}{new_hash}".encode()).hexdigest()
new_hash = self._md5_hash(f"{hashable_string}{new_hash}".encode())
type(self).fingerprints[new_hash] = self
return new_hash

Expand Down Expand Up @@ -114,6 +115,11 @@ def column(self, value):
raise ValueError(f"Expected column number greater than 0; Got {column_number}")
self._column = column_number

def _md5_hash(self, data: bytes) -> str:
if sys.version_info >= (3, 9):
return hashlib.md5(data, usedforsecurity=False).hexdigest() # noqa: S324
return hashlib.md5(data).hexdigest() # noqa: S324

def to_dict(self):
"""Returns the code quality finding as dictionary with a unique fingerprint.

Expand Down