fix popover effect when host is not connected to the document #175
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the updated
$effectcallback, ifelisn't found during the initial render, this$effectwon't trigger theisVisiblerune. Even ifelbecomes available later, this effect won't be activated again whenisVisiblechanges.Why isn't
elfound during the first render? In our scenario,prosemirror-adapterdynamically mounts the Svelte component into adivelement that isn't controlled by Svelte. When the Svelte component is mounted,$effectwill be called, but the hostdivelement isn't yet connected to the document, sodocument.getElementById()will return nothing. This issue was first reported in prosekit/prosemirror-adapter#163.Minimal reproduction for this issue:
https://github.com/ocavue/meltui-pm-adapter-modal-issue
Clicking the first button should display the popover content.
Before:
m-before.mp4
After:
m-after.mp4