Fix single-track storage endpoints #109
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Noarkhh
force-pushed
the
fix-storage-endpoints
branch
2 times, most recently
from
e523c71 to
a0b8130
Compare
Noarkhh
force-pushed
the
fix-storage-endpoints
branch
from
a0b8130 to
f6ac0a1
Compare
varsill
approved these changes
Oct 3, 2025
mat-hek
reviewed
Oct 3, 2025
Comment on lines
+26
to
+36
| pipeline_tail = fn builder -> | ||
| builder | ||
| |> child(:aac_audio_transcoder, %Membrane.Transcoder{ | ||
| output_stream_format: AAC, | ||
| transcoding_policy: transcoding_policy | ||
| }) | ||
| |> child(:file_sink, %Membrane.File.Sink{location: location}) | ||
| end | ||
|
|
||
| spec = | ||
| StorageEndpoints.get_spec_for_single_track_output(:audio, track_builders, pipeline_tail) |
There was a problem hiding this comment.
NIT: IMO it would feel more natural this way:
Suggested change
| pipeline_tail = fn builder -> | |
| builder | |
| |> child(:aac_audio_transcoder, %Membrane.Transcoder{ | |
| output_stream_format: AAC, | |
| transcoding_policy: transcoding_policy | |
| }) | |
| |> child(:file_sink, %Membrane.File.Sink{location: location}) | |
| end | |
| spec = | |
| StorageEndpoints.get_spec_for_single_track_output(:audio, track_builders, pipeline_tail) | |
| StorageEndpoints.get_spec_for_single_track_output(:audio, track_builders, fn builder -> | |
| builder | |
| |> child(:aac_audio_transcoder, %Membrane.Transcoder{ | |
| output_stream_format: AAC, | |
| transcoding_policy: transcoding_policy | |
| }) | |
| |> child(:file_sink, %Membrane.File.Sink{location: location}) | |
| end) |
Comment on lines
+30
to
+31
| not Enum.empty?(Enum.filter(input_kinds, &(&1 in output_kinds))), | ||
| do: {input_path, output_type, Enum.filter(input_kinds, &(&1 in output_kinds))} |
There was a problem hiding this comment.
Suggested change
| not Enum.empty?(Enum.filter(input_kinds, &(&1 in output_kinds))), | |
| do: {input_path, output_type, Enum.filter(input_kinds, &(&1 in output_kinds))} | |
| kinds = Enum.filter(input_kinds, &(&1 in output_kinds)), | |
| not Enum.empty?(kinds), | |
| do: {input_path, output_type, kinds} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.