chore: make it pretty

Author: r0b1n

packages/pluggableWidgets/file-uploader-web/src/components/ActionButton.tsx

@@ -10,7 +10,7 @@ interface ActionButtonProps {
     isDisabled: boolean;
 }
 
-export function ActionButton({ action, icon, title, isDisabled }: ActionButtonProps) {
+export function ActionButton({ action, icon, title, isDisabled }: ActionButtonProps): ReactElement {
     const onClick = useCallback(
         (e: MouseEvent<HTMLButtonElement>) => {
             e.stopPropagation();
@@ -39,7 +39,7 @@ interface FileActionButtonProps {
     icon: ReactElement;
 }
 
-export function FileActionButton({ listAction, store, title, icon }: FileActionButtonProps) {
+export function FileActionButton({ listAction, store, title, icon }: FileActionButtonProps): ReactElement {
     const action = useCallback(() => {
         store.executeAction(listAction);
     }, [store, listAction]);

packages/pluggableWidgets/file-uploader-web/src/components/ActionsBar.tsx

@@ -18,14 +18,15 @@ export const ActionsBar = ({ actions, store }: ButtonsBarProps): ReactElement |
     if (actions && store.canExecuteActions) {
         return (
             <div className={"entry-details-actions"}>
-                {actions.map(a => {
+                {actions.map((a, i) => {
                     if (!a.buttonIsVisible.value) {
                         return null;
                     }
                     const listAction = a.buttonActionImage ?? a.buttonActionFile;
 
                     return (
                         <FileActionButton
+                            key={i}
                             icon={<IconInternal icon={a.buttonIcon.value} className={"file-action-icon"} />}
                             title={a.buttonCaption.value}
                             store={store}
@@ -40,7 +41,7 @@ export const ActionsBar = ({ actions, store }: ButtonsBarProps): ReactElement |
     return null;
 };
 
-function DefaultActionsBar(props: ButtonsBarProps) {
+function DefaultActionsBar(props: ButtonsBarProps): ReactElement {
     const translations = useTranslationsStore();
 
     const onRemove = useCallback(() => {
@@ -54,13 +55,13 @@ function DefaultActionsBar(props: ButtonsBarProps) {
     return (
         <div className={"entry-details-actions"}>
             <ActionButton
-                icon={<span className={"download-icon"} aria-hidden={true} />}
+                icon={<span className={"download-icon"} aria-hidden />}
                 title={translations.get("downloadButtonTextMessage")}
                 action={onViewClick}
                 isDisabled={!props.store.canDownload}
             />
             <ActionButton
-                icon={<span className={"remove-icon"} aria-hidden={true} />}
+                icon={<span className={"remove-icon"} aria-hidden />}
                 title={translations.get("removeButtonTextMessage")}
                 action={onRemove}
                 isDisabled={!props.store.canRemove}

packages/pluggableWidgets/file-uploader-web/src/components/FileEntry.tsx

@@ -87,9 +87,9 @@ function FileEntry(props: FileEntryProps): ReactElement {
                 invalid: props.fileStatus === "validationError"
             })}
             title={props.title}
-            tabIndex={!!defaultAction ? 0 : undefined}
-            onClick={!!defaultAction ? onClick : undefined}
-            onKeyDown={!!defaultAction ? onKeyDown : undefined}
+            tabIndex={defaultAction ? 0 : undefined}
+            onClick={defaultAction ? onClick : undefined}
+            onKeyDown={defaultAction ? onKeyDown : undefined}
         >
             <div className={"entry-details"}>
                 <div

packages/pluggableWidgets/file-uploader-web/src/stores/FileStore.ts

@@ -64,7 +64,7 @@ export class FileStore {
         });
     }
 
-    markMissing() {
+    markMissing(): void {
         this.fileStatus = "missing";
         this._mxObject = undefined;
         this._objectItem = undefined;
@@ -107,7 +107,7 @@ export class FileStore {
             runInAction(() => {
                 this.fileStatus = "done";
             });
-        } catch (e: unknown) {
+        } catch (_e: unknown) {
             runInAction(() => {
                 this.fileStatus = "uploadingError";
             });

packages/pluggableWidgets/file-uploader-web/src/utils/DatasourceUpdateProcessor.ts

@@ -45,8 +45,8 @@ export class DatasourceUpdateProcessor {
             currentItemsSet.add(item.id);
         });
 
-        let newItems = new Set([...currentItemsSet].filter(x => !this.seenItems.has(x)));
-        let missingItems = new Set([...this.seenItems].filter(x => !currentItemsSet.has(x)));
+        const newItems = new Set([...currentItemsSet].filter(x => !this.seenItems.has(x)));
+        const missingItems = new Set([...this.seenItems].filter(x => !currentItemsSet.has(x)));
 
         // missing
         for (const missingItem of missingItems) {

packages/pluggableWidgets/file-uploader-web/src/utils/__tests__/DatasourceUpdateProcessor.spec.ts

@@ -2,7 +2,7 @@ import { DatasourceUpdateProcessor, DatasourceUpdateProcessorCallbacks } from ".
 import { ListValueBuilder, obj } from "@mendix/widget-plugin-test-utils";
 import { ObjectItem } from "mendix";
 
-let fileHasContentsMock = jest.fn();
+const fileHasContentsMock = jest.fn();
 jest.mock("../mx-data", () => ({
     fileHasContents: (...args: any[]) => fileHasContentsMock(...args)
 }));