[WC-2892]: Calendar improvements #1628
Conversation
rahmanunver
force-pushed
the
spike/WC-2892-calendar-improvements
branch
from
729563e to
092f468
Compare
packages/pluggableWidgets/calendar-web/src/utils/calendar-utils.ts
Outdated
Show resolved
Hide resolved
samuelreichert
force-pushed
the
spike/WC-2892-calendar-improvements
branch
4 times, most recently
from
3c4cc51 to
cf6e6bc
Compare
rahmanunver
force-pushed
the
spike/WC-2892-calendar-improvements
branch
from
83c13d2 to
e45f6cd
Compare
rahmanunver
force-pushed
the
spike/WC-2892-calendar-improvements
branch
2 times, most recently
from
901cdef to
f39a11a
Compare
… adjust time building logic
This reverts commit af8d6d8.
rahmanunver
force-pushed
the
spike/WC-2892-calendar-improvements
branch
from
f39a11a to
fc2c48c
Compare
| <description>The hour at which the day view starts (0–23)</description> | ||
| </property> | ||
| <property key="maxHour" type="integer" defaultValue="24"> | ||
| <caption>Day end hour</caption> | ||
| <description>The hour at which the day view ends (1–24)</description> |
There was a problem hiding this comment.
That is a bit confusing. What (0-23) and (1-24) mean?
There was a problem hiding this comment.
We can probably check if starting hour is less than ending hour in editorConfig. And give an error otherwise.
There was a problem hiding this comment.
These are for start and end hours of the day. Can start 0-23 earliest and end 1-24 latest.
| <enumerationValue key="day">Day</enumerationValue> | ||
| <enumerationValue key="week">Week</enumerationValue> | ||
| <enumerationValue key="month">Month</enumerationValue> | ||
| <enumerationValue key="work_week">Custom</enumerationValue> |
There was a problem hiding this comment.
It should probably say "Custom work-week" or even "Work week".
| <property key="showSunday" type="boolean" defaultValue="false"> | ||
| <caption>Sunday</caption> | ||
| <description>Show Sunday in the custom work-week view</description> | ||
| </property> | ||
| <property key="showSaturday" type="boolean" defaultValue="false"> | ||
| <caption>Saturday</caption> | ||
| <description>Show Saturday in the custom work-week view</description> | ||
| </property> |
There was a problem hiding this comment.
I guess Saturday should go before Sunday as this probably determines order in the UI.
| </property> | ||
| </propertyGroup> | ||
| <propertyGroup caption="Visible days"> | ||
| <property key="showMonday" type="boolean" defaultValue="true"> |
There was a problem hiding this comment.
If those propertties are related to customView only, suffix their name with customView as well as you did with customViewCaption. So customViewShowMonday, etc. Any other related properties can benefit from this approach as well.
Pull request type
New feature (non-breaking change which adds functionality)
Description
Added: