Skip to content

fix: unknown listener type: undefined #1768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jeroen-huizer-conclusion

Pull request type

Bug fix (non-breaking change which fixes an issue)


Description

Using LeafletMap, when locations are configured to have both a title and an onclick action, the browser console would log a warning: unknown listener type: undefined. For us this was quite annoying because we render 100's of locations.

I resolved this by not adding eventhandlers to the marker when the location has a title.
I'm not sure whether GoogleMap also has this issue.

What should be covered while testing?

  • When a location does not have a title and does not have an onclick action: clicking should do nothing
  • When a location has a title, but not an onclick: clicking should open a popup
  • When a location does not have a title, but does have an onclick: clicking the location should execute the onclick action
  • When a location has a title and an onclick action: clicking should open a popup, clicking the popup should execute the action

@jeroen-huizer-conclusion jeroen-huizer-conclusion requested a review from a team as a code owner July 11, 2025 13:10
- fix unknown listener type: undefined
- update test spec
@gjulivan gjulivan force-pushed the fix/unknown-listener-type branch from dc63f8d to d05c15e Compare July 14, 2025 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant