fix: unknown listener type: undefined #1768
Open
+1
−13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Bug fix (non-breaking change which fixes an issue)
Description
Using
LeafletMap
, when locations are configured to have both a title and an onclick action, the browser console would log a warning:unknown listener type: undefined
. For us this was quite annoying because we render 100's of locations.I resolved this by not adding eventhandlers to the marker when the location has a title.
I'm not sure whether
GoogleMap
also has this issue.What should be covered while testing?