Skip to content

[WC-3140]: append date on search params instead of replace params #1959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 31, 2025
Merged

[WC-3140]: append date on search params instead of replace params #1959

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8ecbaba
fix: append date on search params instead of replace params
samuelreichert Oct 29, 2025
84e138a
chore(web-actions): update changelog
samuelreichert Oct 29, 2025
3988d23
chore: add mx-global import
samuelreichert Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/modules/web-actions/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),

### Fixed

- We fixed an issue where the search params of a URL were replaced by date on SetFavIcon action.

- We fixed an issue where the default fallback language for any language other than English was Dutch.

## [2.11.0] - 2025-04-16
Expand Down
3 changes: 2 additions & 1 deletion packages/modules/web-actions/src/javascriptsource/webactions/actions/SetFavicon.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
// - the code between BEGIN USER CODE and END USER CODE
// - the code between BEGIN EXTRA CODE and END EXTRA CODE
// Other code you write will be lost the next time you deploy the project.
import "mx-global";
import { Big } from "big.js";

// BEGIN EXTRA CODE
Expand Down Expand Up @@ -41,7 +42,7 @@ export async function SetFavicon(iconUrl16x16, iconUrl32x32, appleTouchIconUrl)
const link = document.createElement("link");
link.href = href;
const bypassCacheHref = new URL(link.href);
bypassCacheHref.search = "v" + Date.now();
bypassCacheHref.searchParams.append("v", Date.now());
link.href = bypassCacheHref.toString();
link.rel = "icon";
if (sizes) {
Expand Down
Loading