Skip to content

Restore Fiberish.X86 native build detection so CI builds generate fibercpu before copy/link steps#2

Merged
meokit merged 2 commits into
mainfrom
copilot/fix-action-failure
Apr 26, 2026
Merged

Restore Fiberish.X86 native build detection so CI builds generate fibercpu before copy/link steps#2
meokit merged 2 commits into
mainfrom
copilot/fix-action-failure

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 26, 2026

Recent CI runs regressed because Fiberish.X86 stopped detecting the in-repo libfibercpu source tree during project evaluation. As a result, MSBuild skipped the native CMake target and later failed when packaging/linking fibercpu outputs across Linux, macOS, Windows, and browser-wasm builds.

  • What changed

    • Moved LibFibercpuSourceDir and LibFibercpuSourceExists back into the top-level PropertyGroup in Fiberish.X86.csproj.
    • This restores evaluation-time availability for:
      • BuildNativeLib target conditions
      • incremental native build inputs
      • output copy/link items that depend on generated native artifacts
  • Why this matters

    • The incremental-build refactor left source detection scoped too narrowly, so BuildNativeLib could be skipped before MSBuild knew the native source tree existed.
    • Restoring these properties at project scope ensures CMake runs before managed build steps attempt to copy libfibercpu.so, libfibercpu.dylib, fibercpu.dll, or libfibercpu.a.
  • Effect on build paths

    • Unblocks dynamic library copy on host/native targets.
    • Unblocks static archive generation for browser-wasm.
    • Preserves the existing RID-specific native output layout and incremental tracking behavior.
  • Representative change

<PropertyGroup>
  <LibFibercpuSourceDir>$(MSBuildThisFileDirectory)../libfibercpu</LibFibercpuSourceDir>
  <LibFibercpuSourceExists Condition="Exists('$(LibFibercpuSourceDir)/CMakeLists.txt')">true</LibFibercpuSourceExists>
  <LibFibercpuSourceExists Condition="'$(LibFibercpuSourceExists)' == ''">false</LibFibercpuSourceExists>
</PropertyGroup>

Copilot AI and others added 2 commits April 26, 2026 12:27
@meokit meokit marked this pull request as ready for review April 26, 2026 12:37
@meokit meokit merged commit 3bacc50 into main Apr 26, 2026
3 checks passed
@meokit meokit deleted the copilot/fix-action-failure branch April 26, 2026 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants