Restore Fiberish.X86 native build detection so CI builds generate fibercpu before copy/link steps#2
Merged
Merged
Conversation
Agent-Logs-Url: https://github.com/meokit/podish/sessions/1355d99e-2647-4572-84d2-5fe78cbfe384 Co-authored-by: meokit <16623696+meokit@users.noreply.github.com>
Agent-Logs-Url: https://github.com/meokit/podish/sessions/1355d99e-2647-4572-84d2-5fe78cbfe384 Co-authored-by: meokit <16623696+meokit@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
meokit
April 26, 2026 12:37
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recent CI runs regressed because
Fiberish.X86stopped detecting the in-repolibfibercpusource tree during project evaluation. As a result, MSBuild skipped the native CMake target and later failed when packaging/linkingfibercpuoutputs across Linux, macOS, Windows, and browser-wasm builds.What changed
LibFibercpuSourceDirandLibFibercpuSourceExistsback into the top-levelPropertyGroupinFiberish.X86.csproj.BuildNativeLibtarget conditionsWhy this matters
BuildNativeLibcould be skipped before MSBuild knew the native source tree existed.libfibercpu.so,libfibercpu.dylib,fibercpu.dll, orlibfibercpu.a.Effect on build paths
browser-wasm.Representative change