propagate labels from tortoise to HPA/VPA managed by tortoise#432
Open
minhthong582000 wants to merge 2 commits intomercari:mainfrom
Open
propagate labels from tortoise to HPA/VPA managed by tortoise#432minhthong582000 wants to merge 2 commits intomercari:mainfrom
minhthong582000 wants to merge 2 commits intomercari:mainfrom
Conversation
minhthong582000
force-pushed
the
labels-vpa-hpa
branch
from
d7bfcdc to
b4ebce4
Compare
Collaborator
|
#433 will fix the ci |
minhthong582000
force-pushed
the
labels-vpa-hpa
branch
2 times, most recently
from
609ed51 to
ece642a
Compare
sanposhiho
reviewed
Mar 12, 2025
Collaborator
sanposhiho
left a comment
sanposhiho
left a comment
There was a problem hiding this comment.
can you add a new test case or edit existing test case in the controller level test to ensure this behaviour?
https://github.com/mercari/tortoise/blob/main/internal/controller/tortoise_controller_test.go
Signed-off-by: minhthong582000 <[email protected]>
minhthong582000
force-pushed
the
labels-vpa-hpa
branch
from
ece642a to
ae81323
Compare
Signed-off-by: minhthong582000 <[email protected]>
minhthong582000
commented
Mar 12, 2025
Comment on lines
-431
to
+436
| It("TortoisePhaseInitializing", func() { | ||
| It("TortoisePhaseInitializing with horizontalPodAutoscalerName configured", func() { | ||
| runTest(filepath.Join("testdata", "reconcile-for-the-single-container-pod-initializing")) | ||
| }) | ||
| It("TortoisePhaseInitializing without horizontalPodAutoscalerName configured", func() { | ||
| runTest(filepath.Join("testdata", "reconcile-for-the-single-container-pod-managed-hpa-initializing")) | ||
| }) |
Author
There was a problem hiding this comment.
These test cases are added/reused to cover scenarios where HPA/VPA is being initialized
| }) | ||
| Context("mutable AutoscalingPolicy", func() { | ||
| It("Tortoise get Horizontal and create HPA", func() { | ||
| It("Tortoise get Horizontal and create HPA (with the same labels)", func() { |
Collaborator
|
@AVSBharadwaj @jrbangit @AdityaK011 Do you want to take a look, as a reviewing training? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Handle label propagation for Tortoise-managed HPA/VPA to ensure consistent across all Kubernetes resources, which allows us to attribute resources by teams or projects, or manage logical links between resources. This also help us to have monitoring and reporting based on labels.
Which issue(s) this PR fixes:
Implements #430
Special notes for your reviewer:
N/A