Fix/kustomize issues 435 440

[anridig]

Summary

This PR aims to fix issues #435 and #440

✅ Key Fixes Applied:

1. Fixed deprecated syntax in all kustomization.yaml files:
   • Removed path: prefix from patchesStrategicMerge entries
   • Added proper apiVersion: kustomize.config.k8s.io/v1beta1 and kind: Kustomization headers
   • Updated bases: to resources: in default kustomization
2. Resolved service name conflicts:
   • Renamed controller-manager-metrics-service to tortoise-metrics-service in config/default/metrics_service.yaml to avoid collision with RBAC proxy service
3. Updated deprecated vars to replacements:
   • Converted the old vars section to modern replacements syntax for webhook configuration
   • Applied kustomize edit fix to automatically convert deprecated patchesStrategicMerge to patches
4. Removed missing file references:
   • Eliminated reference to non-existent manager_metrics_patch.yaml
5. Added validation to Makefile:
   • Created new validate-kustomize target that validates syntax before deployment
   • Updated install and deploy targets to include validation step

✅ Files Modified:

• Makefile - Added validation targets
• config/default/kustomization.yaml - Major syntax updates and replacements conversion
• config/default/metrics_service.yaml - Renamed service to avoid conflicts
• All other config/*/kustomization.yaml files - Added proper headers and fixed syntax

[anridig]

⚠️ ⚠️ ⚠️ This fix was implemented by Claude Code entirely based on an action plan created by Claude.ai 4.0 Sonnet ⚠️ ⚠️ ⚠️

There's always a possibility that Claude Code misunderstood something very fundamental about the codebase, so this PR needs to be thoroughly reviewed by a maintainer ❗

[AVSBharadwaj]

There was a similar fix PR raised by JR : #439

[dyennam-ach]

any update on this? still an ongoing issue when we try to make install/deploy