Skip to content

(do not merge): upgrade jackson to 2.17.1 #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@ repositories {

dependencies {
api 'com.squareup.okhttp3:okhttp:4.12.0'
api 'com.fasterxml.jackson.core:jackson-databind:2.13.0'
api 'com.fasterxml.jackson.datatype:jackson-datatype-jdk8:2.12.3'
api 'com.fasterxml.jackson.datatype:jackson-datatype-jsr310:2.12.3'
api 'com.fasterxml.jackson.core:jackson-databind:2.17.2'
api 'com.fasterxml.jackson.datatype:jackson-datatype-jdk8:2.17.2'
api 'com.fasterxml.jackson.datatype:jackson-datatype-jsr310:2.17.2'
testImplementation 'org.junit.jupiter:junit-jupiter-api:5.8.2'
testImplementation 'org.junit.jupiter:junit-jupiter-engine:5.8.2'
}
Expand Down
44 changes: 22 additions & 22 deletions src/main/java/com/merge/api/core/ApiError.java
Original file line number Diff line number Diff line change
@@ -1,28 +1,28 @@
/**
* This file was auto-generated by Fern from our API Definition.
*/
package com.merge.api.core;
/**
* This file was auto-generated by Fern from our API Definition.
*/
package com.merge.api.core;

public final class ApiError extends RuntimeException {
private final int statusCode;
public final class ApiError extends RuntimeException {
private final int statusCode;

private final Object body;
private final Object body;

public ApiError(int statusCode, Object body) {
this.statusCode = statusCode;
this.body = body;
}
public ApiError(int statusCode, Object body) {
this.statusCode = statusCode;
this.body = body;
}

public int statusCode() {
return this.statusCode;
}
public int statusCode() {
return this.statusCode;
}

public Object body() {
return this.body;
}
public Object body() {
return this.body;
}

@java.lang.Override
public String toString() {
return "ApiError{" + "statusCode: " + statusCode + ", body: " + body + "}";
}
}
@java.lang.Override
public String toString() {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not to move it to imports?

return "ApiError{" + "statusCode: " + statusCode + ", body: " + body + "}";
}
}
21 changes: 18 additions & 3 deletions src/test/java/com/merge/api/TestClient.java
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,24 @@
*/
package com.merge.api;

import com.fasterxml.jackson.core.JsonProcessingException;
import com.merge.api.core.ObjectMappers;
import com.merge.api.resources.ticketing.types.AccountToken;
import org.junit.jupiter.api.Test;

public final class TestClient {
public void test() {
// Add tests here and mark this file in .fernignore
assert true;

@Test
public void test_serde() throws JsonProcessingException {
String json =
"{\"account_token\":\"08JUhtxTFaOmfFsbMBNGx9zPCkRNnOd_NBn-O9XMN99PZ7vs22D1gA\",\"integration\":{\"name\":\"Azure DevOps\",\"abbreviated_name\":null,\"categories\":[\"ticketing\"],\"image\":\"https://merge-api-production.s3.amazonaws.com/media/Azure_DevOps.png\",\"square_image\":\"https://merge-api-production.s3.amazonaws.com/media/Azure_DevOps_Square_Logo.png\",\"color\":\"#0078D4\",\"slug\":\"azure-devops\",\"api_endpoints_to_documentation_urls\":{\"GET\":[],\"POST\":[],\"PATCH\":[]},\"webhook_setup_guide_url\":\"\",\"category_beta_status\":{}}}\n"
+ "\n"
+ "\n"
+ "\n"
+ "\n"
+ "\n"
+ "\n";
Comment on lines +17 to +22
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does it make any sense for the test to add so many "\n"?

AccountToken a = ObjectMappers.JSON_MAPPER.readValue(json, AccountToken.class);
a.getAccountToken();
}
}
Loading