Iconify Support

[noobToLinux]

Hello, I have been working on implementing iconify icons I have made it possible like this and with an extension I did.

FIRST OF ALL: This changes are meaningless without the extension that I did. Check the repo, everything is documented in the README.

The extension is not yet in the marketplace since I need to pay the fee but for security reasons, I can't pay it yet.

Before you read the changes, I would like to comment about the insane amount of commits.
Basically, I am not a web dev and it was the first time I used the svelte, CI CD pipelines, prettier, and so for, so I had an insane amount of errors that had to solve with chatGPT over and over again.

Basically I expected an easy JS problem and found many TS rules that I didn't know of.

The core changes are only on the mermaid file and I think they are easy to interpret. The other files were changed due to CI pipelines errors that I didn't know how to solve. I am sure you will find a way to fix it.

Currently to check the implementation, you will need to install the extension and try it on the mermaid live editor deployed to my repo. Click here

Thanks.

[netlify]

✅ Deploy Preview for mermaidjs ready!

Name	Link
🔨 Latest commit	f688cee
🔍 Latest deploy log	https://app.netlify.com/sites/mermaidjs/deploys/679cb63e0c193f00086ca569
😎 Deploy Preview	https://deploy-preview-1597--mermaidjs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[noobToLinux]

To clarify, idk about CI CD and neither about deploying locally, and I used almost the same one that you have to deploy to my github pages, so my way to go was to commit and push and let github tell me the errors. That is why there is an insane amount of commits. Sorry for that.

[sidharthv96]

I don't think we can support an external extension for this purpose. But, we can add support for that in the editor directly.
I'm willing to help you with that if you're interested.

[noobToLinux]

Hello, and thanks for replying so soon.

I am sorry I don't think I understand your sentence. And also I think we have some language issues here, this is my first experience as open source support and I have no clue about teams workflows, I have always been a lone programmer.

What do you mean by adding support to "that", you mean making my "implementation"? If that is the case, I am ok with it.

About the support for an external extension, I am not sure about what you mean about supporting it. To my point of view, it is just an extension that you or me can publish it, since it is running on the client I don't think it could involve any security issue to you, and I could name it as Unofficial to show that it is not. Always transparent in this topic.

In any case, if you by adding support to the live editor you mean, implementing a way to add your icons, yes, I am interested. However I must say that I think it could be more of a pain to you than to me. My idea, would be to add another button next to "save to mermaid chart" that adds what I do with my extension, but this will involve that you tell me where to do it and how to design the UI to match the current style, something I am blank at, in terms of designing or structuring the code.

In any case thanks for the support.