Skip to content

Adding hyperlink to 'New: Kanvas Snapshots'#78

Open
kunal639 wants to merge 4 commits intomeshery-extensions:masterfrom
kunal639:Feature/adding_hyperlink_to_new_kanvas_snapshot
Open

Adding hyperlink to 'New: Kanvas Snapshots'#78
kunal639 wants to merge 4 commits intomeshery-extensions:masterfrom
kunal639:Feature/adding_hyperlink_to_new_kanvas_snapshot

Conversation

@kunal639
Copy link
Contributor

Notes for Reviewers

This PR fixes #76

  • This PR adds an anchor tag to the hero-glass.html file, introducing a "New: Kanvas Snapshots" pill that links users to the relevant documentation.

Signed commits

  • Yes, I signed my commits.

Changes:

  • Modified hero-glass.html to include the link and span with the .pill class.
  • Verified that the link opens in a new tab.

@github-actions
Copy link

github-actions bot commented Jan 30, 2026

🚀 Preview deployment for PR #78

🌐 Preview URL: https://meshery-extensions.github.io/kanvas-site/pr-preview/pr-78/

This preview will be updated automatically when you push new commits to this PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It wouldn't be better to completely remove the span tag?
And add its class to the a tag?
I don't see the utility of having that span there any longer.
Is just a suggestion

Copy link
Contributor Author

@kunal639 kunal639 Jan 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Katotodan You are right. I will remove the redundant and move the pill class directly to the tag. This definitely makes the DOM cleaner. Thanks for the catch!

Updated the link and moved the .pill class directly to the anchor tag for a cleaner DOM structure, as suggested during review.

Signed-off-by: Kunal Anand <86676795+kunal639@users.noreply.github.com>
@Katotodan
Copy link
Contributor

Can you add screenshot of that section after your change?
Try to run it locally then take a screenshot of that specific section (in the browser).
That will make review easy.

@kunal639
Copy link
Contributor Author

kunal639 commented Feb 4, 2026

@Katotodan Ok. I will do it right away.

Capture Capture5 Capture6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add hyperlink to "New: Kanvas Snapshots"

2 participants