Adding hyperlink to 'New: Kanvas Snapshots'#78
Adding hyperlink to 'New: Kanvas Snapshots'#78kunal639 wants to merge 4 commits intomeshery-extensions:masterfrom
Conversation
|
🚀 Preview deployment for PR #78 🌐 Preview URL: https://meshery-extensions.github.io/kanvas-site/pr-preview/pr-78/ This preview will be updated automatically when you push new commits to this PR. |
There was a problem hiding this comment.
It wouldn't be better to completely remove the span tag?
And add its class to the a tag?
I don't see the utility of having that span there any longer.
Is just a suggestion
There was a problem hiding this comment.
@Katotodan You are right. I will remove the redundant and move the pill class directly to the tag. This definitely makes the DOM cleaner. Thanks for the catch!
Updated the link and moved the .pill class directly to the anchor tag for a cleaner DOM structure, as suggested during review. Signed-off-by: Kunal Anand <86676795+kunal639@users.noreply.github.com>
|
Can you add screenshot of that section after your change? |
|
@Katotodan Ok. I will do it right away. |
Notes for Reviewers
This PR fixes #76
hero-glass.htmlfile, introducing a "New: Kanvas Snapshots" pill that links users to the relevant documentation.Signed commits
Changes:
hero-glass.htmlto include the link and span with the.pillclass.