chore(workflows): audit preview workflows, pin actions to SHA, and clean up dead code - #65
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (8)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughChangesWorkflow and documentation build maintenance
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
banana-three-join
left a comment
There was a problem hiding this comment.
Please keep the scope of the audit only to the Build Site Preview and the Site Preview Post-Build workflows. Revert on the changes made to any of the other workflows.
…nd hugo version - Reverted changes on non-preview workflows (build-and-release, label-commenter, labeler, release-drafter, slack) per review request. - Retained SHA pinning on deploy-docs-preview.yml. - Retained dead code removal in build-docs-preview.yml. - Retained preview deployment comment format update in deploy-docs-preview.yml. - Retained Hugo min version alignment (0.158.0) in hugo.yaml. Signed-off-by: MrDadhich456 <aaryandadhich2006@gmail.com>
df8207f to
5943b9b
Compare
Thanks for the review @banana-three-join! 🙌 I've updated the PR to restrict the audit scope strictly to the site preview workflows ( |
Summary of Audit & Changes (
tcslabs-academy)This PR performs a full workflow audit and cleanup for
tcslabs-academyin accordance with the workflow evaluation guidelines.📋 Audit Points Overview
Repo Assignment:
meshery-extensions/tcslabs-academyTest PR Scope:
pull_request_targetTriggers Audit:label-commenter.yml(Line 8):on: pull_request_target(triggers label-commenter on PR labels)labeler.yml(Line 3):on: pull_request_target(triggers triage labeler)wait-for-pages-deployment: falseCheck:gh-pagesbranch usingrossjrw/pr-preview-actionand do not utilizeactions/deploy-pages.Pin Actions to Commit SHAs (Latest Major Versions):
build-and-release.yml:actions/checkout: Pinned to SHA3d3c42e5aac5ba805825da76410c181273ba90b1(# v7.0.1)actions/setup-go: Upgraded v5 → v7, pinned tob7ad1dad31e06c5925ef5d2fc7ad053ef454303e(# v7.0.0)actions/setup-node: Pinned to820762786026740c76f36085b0efc47a31fe5020(# v7.0.0)layer5io/academy-build: Pinned to657b2ecc9e146aaf6b698851bd0c151e489ad668(# v0.1.6)deploy-docs-preview.yml:actions/download-artifact: Pinned tod3f86a106a0bac45b974a628896c90dbdf5c8093(# v4.3.0)actions/checkout: Pinned to3d3c42e5aac5ba805825da76410c181273ba90b1(# v7.0.1)actions/github-script: Pinned toed597411d8f924073f98dfc5c65a23a2325f34cd(# v8.0.0)label-commenter.yml:actions/checkout: Upgradedmaster→v7, pinned to3d3c42e5aac5ba805825da76410c181273ba90b1(# v7.0.1)peaceiris/actions-label-commenter: Pinned tof0dbbef043eb1b150b566db36b0bdc8b7f505579(# v1.10.0)labeler.yml:actions/labeler: Upgraded v4 → v5, pinned to8558fd74291d67161a8a78ce36a881fa63b766a9(# v5.0.0)release-drafter.yml:release-drafter/release-drafter: Upgraded v5 → v6, pinned to6a93d829887aa2e0748befe2e808c66c0ec6e4c7(# v6.4.0)slack.yml:slackapi/slack-github-action: Pinned to91efab103c0de0a537f72a35f6b8cda0ee76bf0a(# v2.1.1)Hugo Version Consistency:
hugo.yaml: UpdatedminHugo version from0.156.0to0.158.0to matchpackage.json(hugo-extended:0.158.0).Remove Dead Hugo CLI & Dart Sass Setup:
build-docs-preview.yml: Removed redundant commented-outInstall Hugo CLIandInstall Dart Sasssteps andHUGO_VERSIONenvironment block, asnpm ciinstallshugo-extendedautomatically.Deployment Comment Format:
deploy-docs-preview.yml: Updated preview deployment message template to include tracking link to GitHub Actions pages deployment.Summary by CodeRabbit
Chores
Documentation