Closed
Conversation
Changed how isEmoji detection works due to a change on the Android client.
Contributor
There was a problem hiding this comment.
Pull request overview
Updates tapback (reaction) detection in the iOS message parser to align with newer Android behavior where decoded.emoji may contain an emoji ID (non-zero) rather than a strict boolean 1.
Changes:
- Treat any non-zero
packet.decoded.emojivalue as a tapback/reaction when creatingMessageEntityinstances.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
this is an android bug |
8 tasks
|
Android says Apple is doing it wrong. meshtastic/Meshtastic-Android#4417 Edit: per discussion, Apple is correct and Android needs to fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed how isEmoji detection works due to a change on the Android client.
What changed?
Change made to isEmoji detection from
packet.decoded.emoji == 1topacket.decoded.emoji != 0within the MeshPackets file.Why did it change?
Issue 1579
The android client changed how the handle sending emoji information, moving from using 0 as false, and 1 as true, to using the emoji ID. This resulted in tapbacks being sent from the android client to arrive on the iPhone as a new message.
How is this tested?
I removed the entitlements for critical message, carplay, associated domains, and weather kit so I could self sign and install on my iPad. I then tested messaging between apple, android, and web via hardware.
I did find that web does not seem to currently support tapback.
Screenshots/Videos (when applicable)
Checklist