Fix connectToPreferredDevice parameter type to resolve compilation error#1590
Merged
Fix connectToPreferredDevice parameter type to resolve compilation error#1590
Conversation
|
|
…meter Co-authored-by: garthvh <1795163+garthvh@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] WIP address feedback on pull request 2.7.8
Fix connectToPreferredDevice parameter type to resolve compilation error
Feb 12, 2026
garthvh
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Changed
connectToPreferredDevicefunction signature fromdevice: Devicetodevice: Device? = nilinAccessoryManager.swift.Why did it change?
The function used nil-coalescing operator (
device ?? fallback) on a non-optional parameter, which fails to compile. Making the parameter optional with a default value:How is this tested?
Existing call sites in
AccessoryManager+Discovery.swiftcontinue to work unchanged. Function can now also be called with no arguments.Screenshots/Videos (when applicable)
N/A - Internal API change with no UI impact.
Checklist
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.