Skip to content

Conversation

oscgonfer
Copy link
Contributor

@oscgonfer oscgonfer commented Jun 15, 2025

Works on #7047, with tests on-going at the moment. It doesn't add non-present values in the telemetry module.

In addition, it adds a small convention to change battery level to -1 when not present. (To be reviewed based on the discussion in meshtastic/protobufs#706).

Finally, as a side benefit, removing these fields from the payload reduces the size of the payload in many cases.

🤝 Attestations

  • I have tested that my proposed changes behave as described.
  • I have tested that my proposed changes do not cause any obvious regressions on the following devices:
    • ...
    • Other (please specify below)
    • Xiao ESP32-S3 + SX1262 (ongoing)

@CLAassistant
Copy link

CLAassistant commented Jun 15, 2025

CLA assistant check
All committers have signed the CLA.

@oscgonfer oscgonfer marked this pull request as draft June 15, 2025 21:45
Copy link
Member

@fifieldt fifieldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The files under src/generated/meshtastic are automatically generated, using protobufs , so can't be edited here.

See: https://github.com/meshtastic/protobufs

@oscgonfer
Copy link
Contributor Author

oscgonfer commented Jun 16, 2025

The files under src/generated/meshtastic are automatically generated, using protobufs , so can't be edited here.

See: https://github.com/meshtastic/protobufs

I'll fix that! Maybe worth adding that to the .gitignore?

Is this the right approach based on #7047 (comment) ?

@oscgonfer
Copy link
Contributor Author

@fifieldt fixed the generated files. sorry for that! Note that this goes with meshtastic/protobufs#706

@oscgonfer
Copy link
Contributor Author

oscgonfer commented Jun 16, 2025

Just tested again with the node I have at hand (seeed-xiao-s3), and I confirm the changes work as intended in my test:

device/sck/mesh12/2/json/LongFast/!da741924
{"channel":0,"from":3665041700,"hop_start":3,"hops_away":0,"id":68397858,"payload":{"relative_humidity":55.9199981689453,"temperature":27.4300003051758},"sender":"!da741924","timestamp":1750065519,"to":4294967295,"type":"telemetry"}

@oscgonfer oscgonfer marked this pull request as ready for review June 16, 2025 09:21
@oscgonfer oscgonfer force-pushed the enhancement/telemetry-module-payload branch 2 times, most recently from eb24018 to 406f99d Compare June 20, 2025 16:30
@oscgonfer oscgonfer force-pushed the enhancement/telemetry-module-payload branch from 406f99d to 68dd2d7 Compare June 20, 2025 16:35
@thebentern thebentern merged commit 195b7cc into meshtastic:master Jun 21, 2025
43 of 46 checks passed
@oscgonfer oscgonfer deleted the enhancement/telemetry-module-payload branch July 12, 2025 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants