-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Enhancement/telemetry module payload #7048
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement/telemetry module payload #7048
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The files under src/generated/meshtastic are automatically generated, using protobufs , so can't be edited here.
I'll fix that! Maybe worth adding that to the Is this the right approach based on #7047 (comment) ? |
8b6c3f8
to
0cf5006
Compare
@fifieldt fixed the |
Just tested again with the node I have at hand (
|
eb24018
to
406f99d
Compare
406f99d
to
68dd2d7
Compare
Works on #7047, with tests on-going at the moment. It doesn't add
non-present
values in the telemetry module.In addition, it adds a small convention to change battery level to-1
when not present. (To be reviewed based on the discussion in meshtastic/protobufs#706).Finally, as a side benefit, removing these fields from the payload reduces the size of the payload in many cases.
🤝 Attestations