Skip to content

Compress NodeInfoLite bools into a bitfield #668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+9 −15
Open

Compress NodeInfoLite bools into a bitfield #668

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions meshtastic/deviceonly.options
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
*DeviceState.node_remote_hardware_pins max_count:12

*NodeInfoLite.channel int_size:8
*NodeInfoLite.bitfield int_size:8
*NodeInfoLite.hops_away int_size:8
*NodeInfoLite.next_hop int_size:8

Expand Down
23 changes: 8 additions & 15 deletions meshtastic/deviceonly.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,31 +134,24 @@ message NodeInfoLite {
uint32 channel = 7;

/*
* True if we witnessed the node over MQTT instead of LoRA transport
* Bitfield to contain 8 1-bit boolean values.
* 0 - via_mqtt: True if we witnessed the node over MQTT instead of LoRA transport
* 1 - is_favorite: True if node is in our favorites list
* Persists between NodeDB internal clean ups
* 2 - is_ignored: True if node is in our ignored list
* Persists between NodeDB internal clean ups
*/
bool via_mqtt = 8;
uint32 bitfield = 8;

/*
* Number of hops away from us this node is (0 if direct neighbor)
*/
optional uint32 hops_away = 9;

/*
* True if node is in our favorites list
* Persists between NodeDB internal clean ups
*/
bool is_favorite = 10;

/*
* True if node is in our ignored list
* Persists between NodeDB internal clean ups
*/
bool is_ignored = 11;

/*
* Last byte of the node number of the node that should be used as the next hop to reach this node.
*/
uint32 next_hop = 12;
uint32 next_hop = 10;
}

/*
Expand Down