Skip to content

Clarify the use of the "to" field of MeshPacket struct #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
andrewdavidmackenzie wants to merge 4 commits into from
Closed

Clarify the use of the "to" field of MeshPacket struct #79

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d0ef2e9
Handle EOF when DuplexStream is closed, avoiding a panic.
andrewdavidmackenzie Nov 6, 2025
45c7ce0
Additional protection from panics on invalid input buffer lengths.
andrewdavidmackenzie Nov 7, 2025
c43572b
Merge branch 'meshtastic:main' into main
andrewdavidmackenzie Nov 12, 2025
5d7e4ca
Clarify the use of the "to" field of MeshPacket and how to determine …
andrewdavidmackenzie Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/generated/meshtastic.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5111,7 +5111,11 @@ pub struct MeshPacket {
#[prost(fixed32, tag = "1")]
pub from: u32,
///
/// The (immediate) destination for this packet
/// The (immediate) destination for this packet.
Copy link
Collaborator

@lukipuki lukipuki Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the right place for it. As the name suggests, this is a generated file. This will get overwritten when we update protobuf and regenerate this file.

Please post a PR to the protobuf repository:
https://github.com/meshtastic/protobufs/blob/7654db2e2d1834aebde40090a9b74162ad1048ae/meshtastic/mesh.proto#L1373

/// If the value is u32::MAX, this indicates that the packet was not destined for a specific
/// node, but for a channel as indicated by the value of `channel` below.
/// If the value is not u32MAX, this indicates that the packet was destined for a specific
/// node (i.e. a kind of "Direct Message" to this node) and not broadcast on a channel.
#[prost(fixed32, tag = "2")]
pub to: u32,
///
Expand Down