Enhance AIX shared library build to use an export List.#14462
Open
KamathForAIX wants to merge 1 commit intomesonbuild:masterfrom
Open
Enhance AIX shared library build to use an export List.#14462KamathForAIX wants to merge 1 commit intomesonbuild:masterfrom
KamathForAIX wants to merge 1 commit intomesonbuild:masterfrom
Conversation
Contributor
Author
|
Hi @eli-schwartz and community members, I had to close #14335 due to merge conflicts and changes in ninja-backend.py file coming which were not made by me post sync. Apologies for the same. |
jpakkane
reviewed
Apr 16, 2025
| os.environ['PATH'] = origpath | ||
|
|
||
| def aix_syms(libfilename: str, outfilename: str) -> None: | ||
| nm_output = subprocess.run(rf"nm -BCg {libfilename} | egrep ' [TDB] ' | sed -e 's/.* //' | egrep -v '\\$' | sed -e 's/^[.]//' | sort | uniq", |
Member
There was a problem hiding this comment.
Shell pipelines are never acceptable. This same functionality must be provided with Python.
Contributor
Author
There was a problem hiding this comment.
Sure. Thanks, @jpakkane. I will definitely try to change this and will keep it in my mind. As of now, we are redesigning this pull request with @eli-schwartz. Post that I will try.
In case of any constraints will get back.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #14334