Skip to content

Resolves bug #15560 - evaluate qt dependencies without qt framework#15623

Open
boulette42 wants to merge 1 commit into
mesonbuild:masterfrom
boulette42:bug-15560
Open

Resolves bug #15560 - evaluate qt dependencies without qt framework#15623
boulette42 wants to merge 1 commit into
mesonbuild:masterfrom
boulette42:bug-15560

Conversation

@boulette42

@boulette42 boulette42 commented Mar 15, 2026

Copy link
Copy Markdown
Contributor

If qt5 is built from source with parameter '-no-framework', meson did not find the Qt-libraries. Instead of changing an internal flag, the return code of the probing function is now used to determine the existence of the qt framework. The internal flag has to keep its value.

Fixes: #15560

@boulette42 boulette42 requested a review from jpakkane as a code owner March 15, 2026 16:04
@eli-schwartz

Copy link
Copy Markdown
Member

Please update the commit message to use a standard format. e.g. following the guidance at https://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html

In particular, "resolves #15560" should be part of "more detailed explanatory text" because it is a citation that explains "detect non-framework Qt on macOS" -- the bug reference isn't the actual one-line summary itself.

Also, "resolves #xxx" is a keyword recognized by GitHub to automatically close linked tickets, but "resolves bug #xxx" is unfortunately not part of the GitHub regex, so please never use the latter.

If qt5 was built from source with parameter '-no-framework', meson
did not find the Qt-libraries.
Now instead of changing an internal flag, the return code of the
probing function is used to determine the existence of the qt
framework. The internal flag has to keep its value.
This resolves mesonbuild#15560
@boulette42

Copy link
Copy Markdown
Contributor Author

Thank you for your advice.
Is this commit sufficient or do I have to make a new PR?

@bonzini bonzini added this to the 1.12 milestone Apr 24, 2026
@bonzini

bonzini commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

Who sets self.is_found when _framework_detect returns True?

@bonzini bonzini added the needs-info waiting information from user. May close if no response for long time. label Jun 10, 2026
@bonzini

bonzini commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

@boulette42 can you answer the question above?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-info waiting information from user. May close if no response for long time.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dependencies/qt: Third attempt to allow qt --no-framework on MacOS

3 participants