AstInterpreter: Slight Performance Improvement#15754
Merged
Merged
Conversation
Volker-Weissmann
marked this pull request as draft
April 26, 2026 20:20
Volker-Weissmann
force-pushed
the
create_uv
branch
from
April 26, 2026 20:24
01dbaa3 to
162147e
Compare
bonzini
reviewed
Apr 27, 2026
| if self.tainted: | ||
| return UnknownValue() | ||
| else: | ||
| return UndefinedVariable() |
Contributor
There was a problem hiding this comment.
Better:
for nesting, value in reversed(self.cur_assignments[var_name]):
if len(self.nesting) >= len(nesting) and self.nesting[:len(nesting)] == nesting:
return value
if self.tainted:
return UnknownValue()
return UndefinedVariable()Creating an Object of type `UndefinedVariable` takes longer than assigning `None`, and `get_cur_value_if_defined` is executed a lot of times when you run `meson configure` without a build dir. See also: mesonbuild#15743
Volker-Weissmann
force-pushed
the
create_uv
branch
from
April 27, 2026 16:01
162147e to
7f81e91
Compare
Volker-Weissmann
marked this pull request as ready for review
April 27, 2026 16:02
dcbaker
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See discussion at #15743