protobuf: fix compilation on armv6l (libatomic) #2331
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meator
force-pushed
the
protobuf-libatomic
branch
3 times, most recently
from
858631f to
f943416
Compare
meator
force-pushed
the
protobuf-libatomic
branch
5 times, most recently
from
4ac15d3 to
b16c7af
Compare
meator
force-pushed
the
protobuf-libatomic
branch
from
b16c7af to
c8c5ece
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a second architecture-specific issue which cannot be caught CI checks I've dealt with recently. They cannot be caught by CI because CI builds everything statically, so it propagates linker errors to the wrap user, which doesn't exist in CI.
This issue could be solved by setting
default_library=staticin CI only or by adding a small test executable which wouldlink_wholewith all libraries it provides. This would force the linker to resolve all symbols (which will uncover issues like #2282 and the issue this PR solves).In Meson <=1.7.0, I don't check for the edge case where neither libatomic nor builtin support is available. I can add that check if requested.