Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the list endpoint instead of ps to get ollama's models #403

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

geronimo
Copy link

@geronimo geronimo commented Nov 8, 2024

What does this PR do?

Change the endpoint used to determine what models are available in ollama from /api/ps to /api/tags

Feature/Issue validation/testing/test plan

To reproduce the problem observed in the issue above:

  • Start the ollama server (ensure there are compatible models installed)
  • Ensure there is no current process running any model with ollama ps
  • Start the llama-stack server and no model will be found, although the models are usable in ollama

After the change, there is no need to have a process running the models in Ollama. It'll pick them up anyway.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Ran pre-commit to handle lint / formatting issues.
  • Read the contributor guideline,
    Pull Request section?
  • Updated relevant documentation.
  • Wrote necessary unit or integration tests.

@facebook-github-bot
Copy link

Hi @geronimo!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Nov 8, 2024
@ashwinb
Copy link
Contributor

ashwinb commented Nov 12, 2024

change /api/ps to /api/tags

you say /api/tags/ but in the code the change is client.list() -- is that intended?

@geronimo
Copy link
Author

change /api/ps to /api/tags

you say /api/tags/ but in the code the change is client.list() -- is that intended?

@ashwinb, correct, in the ollama client, the list method actually uses the /api/tags/ endpoint. Here is the source.

@aidando73
Copy link
Contributor

aidando73 commented Dec 16, 2024

I've given this a try and it works for me.

It's nice since don't need to run ollama run $OLLAMA_INFERENCE_MODEL --keepalive 60m every hour or if you switch models

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants