create a github action for triggering client-sdk tests on new pull-request #850
+84
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
sixianyi0721
force-pushed
the
testci
branch
20 times, most recently
from
9a84b07 to
7a59e27
Compare
sixianyi0721
changed the title
sixianyi0721
requested review from
ashwinb,
yanxi0830,
hardikjshah,
dltn,
raghotham,
dineshyv and
vladimirivic
as code owners
terrytangyuan
approved these changes
Jan 23, 2025
ashwinb
reviewed
Jan 23, 2025
| name: auto-tests | ||
|
|
||
| on: | ||
| pull_request: |
There was a problem hiding this comment.
I don't think we should automatically run this -- not yet. Can you make sure you keep this action available so people can manually invoke it on a commit?
There was a problem hiding this comment.
yes we also allow manual trigger (line 5)
I don't think we should automatically run this -- not yet.
what is your consideration here?
ashwinb
reviewed
Jan 23, 2025
| test-llama-stack-as-library: | ||
| runs-on: ubuntu-latest | ||
| env: | ||
| TOGETHER_API_KEY: ${{ secrets.TOGETHER_API_KEY }} |
There was a problem hiding this comment.
who can access these secrets? can any public developer invoke the workflow?
There was a problem hiding this comment.
only us can access the secrets but any public developer can invoke the flow
sixianyi0721
force-pushed
the
testci
branch
7 times, most recently
from
ea89cb0 to
294b58c
Compare
sixianyi0721
commented
Jan 23, 2025
.github/workflows/tests.yml
Outdated
| provider: [fireworks, together] | ||
|
|
||
| # Dumb approach to restrict the users who trigger the gh actions | ||
| if: contains('["ashwinb", "yanxi0830", "hardikjshah", "dltn", "raghotham", "dineshyv", "vladimirivic", "sixianyi0721"]', github.actor) |
There was a problem hiding this comment.
Updated such that only those in CODEOWNER files can trigger the gh action. Will follow up with a smarter approach
sixianyi0721
force-pushed
the
testci
branch
4 times, most recently
from
705186d to
94b592d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Create a new github action that runs integration tests on fireworks and together distro upon new PR
Key features:
Next steps:
Test Plan
See the job run triggered by this PR