Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vllm readthedocs #862

Closed
wants to merge 3 commits into from
Closed

Vllm readthedocs #862

wants to merge 3 commits into from

Conversation

heyjustinai
Copy link
Member

added vllm as provider on readthedocs

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Jan 23, 2025
terrytangyuan
terrytangyuan reviewed Jan 23, 2025
View reviewed changes
Copy link
Collaborator

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should automate the sync and then check it as part of the CI instead of doing this manually.

@terrytangyuan terrytangyuan mentioned this pull request Jan 24, 2025
Merged
@ashwinb
Copy link
Contributor

ashwinb commented Jan 28, 2025

This is not needed due to #855.

@terrytangyuan I think maintaining this list is a small thing to do manually and we want to maintain control on what and how we showcase.

@ashwinb ashwinb closed this Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terrytangyuan terrytangyuan terrytangyuan left review comments

@ashwinb ashwinb Awaiting requested review from ashwinb ashwinb is a code owner

@yanxi0830 yanxi0830 Awaiting requested review from yanxi0830 yanxi0830 is a code owner

@hardikjshah hardikjshah Awaiting requested review from hardikjshah hardikjshah is a code owner

@dltn dltn Awaiting requested review from dltn dltn is a code owner

@raghotham raghotham Awaiting requested review from raghotham raghotham is a code owner

@dineshyv dineshyv Awaiting requested review from dineshyv dineshyv is a code owner

@vladimirivic vladimirivic Awaiting requested review from vladimirivic vladimirivic is a code owner

@sixianyi0721 sixianyi0721 Awaiting requested review from sixianyi0721 sixianyi0721 is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@heyjustinai @ashwinb @terrytangyuan @facebook-github-bot