Skip to content

Conversation

@burtenshaw
Copy link
Collaborator

@burtenshaw burtenshaw commented Nov 4, 2025

This PR updates the ci action to use the cli from #144

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Nov 4, 2025
@burtenshaw burtenshaw changed the title [CLI/CI[ use the new cli in ci for pr deployment [CLI/CI] use the new cli in ci for pr deployment Nov 4, 2025
@jspisak jspisak added the enhancement New feature or request label Nov 4, 2025
@zkwentz
Copy link
Contributor

zkwentz commented Nov 5, 2025

This is awesome, thanks for jumping on it quick. Looks good, but before we land we need to convert the existing in-repo environments to be OpenEnv valid (presence of an openenv.yaml, tweaks to dockerfile). Give me 2 hours, will ping here with that PR.

@burtenshaw
Copy link
Collaborator Author

burtenshaw commented Nov 5, 2025

This is awesome, thanks for jumping on it quick. Looks good, but before we land we need to convert the existing in-repo environments to be OpenEnv valid (presence of an openenv.yaml, tweaks to dockerfile). Give me 2 hours, will ping here with that PR.

True @zkwentz . Also note, this action only runs on new prs within src/envs. We have this action which deploys merged envs from main. I think we should update the latter to be openenv push compatible as well..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot. enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants