Add ATen bucketing pass as well #178
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
ezyang
approved these changes
Oct 2, 2025
…sa/add_bucketing_aten
Contributor
Author
|
@eellison looks like CI is OOMing after enabling bucketing. I'll leave this open for now, but I assume you have follow-up work on improving the memory utilization for the reordering / bucketing passes right? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this was missing from #173
Instead of adding it through
torch._inductor.config.test_configs.aten_fx_overlap_preserving_bucketing, I decided to use the basic primitive so that we can more easily configure the bucket size.