feat: add per-table table_constraints event (#4077) - #4162
Closed
ahmed-shuaibi wants to merge 2 commits into
Closed
ahmed-shuaibi wants to merge 2 commits into
ahmed-shuaibi wants to merge 2 commits into
Conversation
added 2 commits
April 23, 2026 09:12
Summary: Log the planner's final per-table assignment (compute_kernel, sharding_type, CLF, HBM/DDR) after planning completes. One Scuba event per table in best_plan, called from both OSS and LP planners next to log_offloading_summary. Reviewed By: hammad45, eugeneshulgameta Differential Revision: D97985051
Summary: Log the parameter constraints passed to the planner per table (compute_kernels, sharding_types, initial CLF, enforce_hbm, SSD offloading). Emitted right after planner_config, before enumerate(), from both OSS and LP planners. Reviewed By: eugeneshulgameta, hammad45 Differential Revision: D98000171
ahmed-shuaibi
force-pushed
the
export-D98000171
branch
from
April 23, 2026 16:12
55e8c7a to
d11392c
Compare
meta-cla
Bot
added
the
CLA Signed
Contributor
|
@ahmed-shuaibi has exported this pull request. If you are a Meta employee, you can view the originating Diff in D98000171. |
ahmed-shuaibi
pushed a commit
to ahmed-shuaibi/torchrec
that referenced
this pull request
Apr 23, 2026
Summary: Log the parameter constraints passed to the planner per table (compute_kernels, sharding_types, initial CLF, enforce_hbm, SSD offloading). Emitted right after planner_config, before enumerate(), from both OSS and LP planners. Reviewed By: eugeneshulgameta, hammad45 Differential Revision: D98000171
ahmed-shuaibi
pushed a commit
to ahmed-shuaibi/torchrec
that referenced
this pull request
Apr 23, 2026
Summary: Log the parameter constraints passed to the planner per table (compute_kernels, sharding_types, initial CLF, enforce_hbm, SSD offloading). Emitted right after planner_config, before enumerate(), from both OSS and LP planners. Reviewed By: eugeneshulgameta, hammad45 Differential Revision: D98000171
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Log the parameter constraints passed to the planner per table (compute_kernels, sharding_types, initial CLF, enforce_hbm, SSD offloading). Emitted right after planner_config, before enumerate(), from both OSS and LP planners.
Reviewed By: eugeneshulgameta, hammad45
Differential Revision: D98000171