Delete HeteroEmbeddingShardingPlanner#4169
Closed
micrain wants to merge 1 commit intometa-pytorch:mainfrom
Closed
Conversation
Summary: Remove HeteroEmbeddingShardingPlanner class from planners.py along with its helper function _merge_plans and the unused MemoryBalancedPartitioner import. Also remove all references in sharding_config.py (import, "hetero" planner branch, docstring), delete the test_infer_hetero_shardings.py test file, and clean up corresponding BUCK targets. Reviewed By: aporialiao Differential Revision: D102251129
meta-cla
Bot
added
the
CLA Signed
Contributor
|
@micrain has exported this pull request. If you are a Meta employee, you can view the originating Diff in D102251129. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Remove HeteroEmbeddingShardingPlanner class from planners.py along with its helper function _merge_plans and the unused MemoryBalancedPartitioner import. Also remove all references in sharding_config.py (import, "hetero" planner branch, docstring), delete the test_infer_hetero_shardings.py test file, and clean up corresponding BUCK targets.
Reviewed By: aporialiao
Differential Revision: D102251129