Add deprecated_aliases to runopt and add warning #1142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1142 +/- ##
==========================================
+ Coverage 91.64% 91.67% +0.02%
==========================================
Files 83 83
Lines 6441 6499 +58
==========================================
+ Hits 5903 5958 +55
- Misses 538 541 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
AbishekS
added a commit
to AbishekS/torchx
that referenced
this pull request
Oct 8, 2025
Summary: Lets introduce `deprecated_aliases` that would warn folks that a specific alias is deprecated. Differential Revision: D84180061
AbishekS
force-pushed
the
export-D84180061
branch
from
9f21e51 to
f93003c
Compare
AbishekS
added a commit
to AbishekS/torchx
that referenced
this pull request
Oct 9, 2025
Summary: Similar to `RunOptAlias` lets introduce and use `RunOptDeprecatedAlias`. This will warn the user with a`UserWarning` when the user uses that specific name and suggests the primary one instead. Differential Revision: D84180061
AbishekS
force-pushed
the
export-D84180061
branch
from
f93003c to
84f36ef
Compare
AbishekS
added a commit
to AbishekS/torchx
that referenced
this pull request
Oct 10, 2025
Summary: Pull Request resolved: meta-pytorch#1142 Similar to `runopt.alias` lets introduce and use `runopt.deprecated_alias`. This will warn the user with a`UserWarning` when the user uses that specific name and suggests the primary one instead. Reviewed By: kiukchung Differential Revision: D84180061
AbishekS
force-pushed
the
export-D84180061
branch
from
84f36ef to
946d61e
Compare
AbishekS
added a commit
to AbishekS/torchx
that referenced
this pull request
Oct 10, 2025
Summary: Pull Request resolved: meta-pytorch#1142 Similar to `runopt.alias` lets introduce and use `runopt.deprecated_alias`. This will warn the user with a`UserWarning` when the user uses that specific name and suggests the primary one instead. Reviewed By: kiukchung Differential Revision: D84180061
AbishekS
force-pushed
the
export-D84180061
branch
from
946d61e to
69c6b8f
Compare
AbishekS
added a commit
to AbishekS/torchx
that referenced
this pull request
Oct 10, 2025
Summary: Pull Request resolved: meta-pytorch#1142 Similar to `runopt.alias` lets introduce and use `runopt.deprecated_alias`. This will warn the user with a`UserWarning` when the user uses that specific name and suggests the primary one instead. Reviewed By: kiukchung Differential Revision: D84180061
AbishekS
force-pushed
the
export-D84180061
branch
from
69c6b8f to
c68321c
Compare
AbishekS
added a commit
to AbishekS/torchx
that referenced
this pull request
Oct 10, 2025
Summary: Pull Request resolved: meta-pytorch#1142 Similar to `runopt.alias` lets introduce and use `runopt.deprecated_alias`. This will warn the user with a`UserWarning` when the user uses that specific name and suggests the primary one instead. Reviewed By: kiukchung Differential Revision: D84180061
AbishekS
force-pushed
the
export-D84180061
branch
from
c68321c to
b60d1d5
Compare
AbishekS
added a commit
to AbishekS/torchx
that referenced
this pull request
Oct 10, 2025
Summary: Similar to `runopt.alias` lets introduce and use `runopt.deprecated`. This will warn the user with a`UserWarning` when the user uses that specific name and suggests the primary one instead. Reviewed By: kiukchung Differential Revision: D84180061
AbishekS
force-pushed
the
export-D84180061
branch
from
b60d1d5 to
a0ef89c
Compare
AbishekS
added a commit
to AbishekS/torchx
that referenced
this pull request
Oct 10, 2025
Summary: Similar to `runopt.alias` lets introduce and use `runopt.deprecated`. This will warn the user with a`UserWarning` when the user uses that specific name and suggests the primary one instead. Reviewed By: kiukchung Differential Revision: D84180061
AbishekS
force-pushed
the
export-D84180061
branch
2 times, most recently
from
6153f53 to
695fd17
Compare
AbishekS
added a commit
to AbishekS/torchx
that referenced
this pull request
Oct 10, 2025
Summary: Similar to `runopt.alias` lets introduce and use `runopt.deprecated`. This will warn the user with a`UserWarning` when the user uses that specific name and suggests the primary one instead. Reviewed By: kiukchung Differential Revision: D84180061
Summary: Lets allow aliases for a runopt. This will give downstream users to have multiple ways of accessing the same runopt. * Introduce new class for `runopt.alias` which is used to expand on adding aliases to a runopt. * Add a new dict to maintain alias to key values that can be used by `opt.get(name)` * Modify add() to accept list as well, build out the aliases list and modify the previously created dict to fill in alias to primary_key values. * Modify resolve() to check if a different alias is already used in cfg i.e if the "jobPriority" and "job_priority" are aliases for the same one, we don't allow for both to be present in the cfg. * Modify get to look at the alias to primary_key dict as well. Differential Revision: D84157870
Summary: Similar to `runopt.alias` lets introduce and use `runopt.deprecated`. This will warn the user with a`UserWarning` when the user uses that specific name and suggests the primary one instead. Reviewed By: kiukchung Differential Revision: D84180061
AbishekS
force-pushed
the
export-D84180061
branch
from
695fd17 to
59f2b0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Lets introduce
deprecated_aliasesthat would warn folks that a specific alias is deprecated.Differential Revision: D84180061