Skip to content

Support user login and registration #495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 23 commits into
base: master
Choose a base branch
from
Open

Support user login and registration #495

wants to merge 23 commits into from

Conversation

amCap1712
Copy link
Member

TBA

@amCap1712 amCap1712 mentioned this pull request Dec 21, 2024
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 21, 2024 •
edited
Loading

Test Results

235 tests  +36   230 ✅ +36   49s ⏱️ +19s
  1 suites ± 0     5 💤 ± 0 
  1 files   ± 0     0 ❌ ± 0 

Results for commit 56e2aae. ± Comparison against base commit 8f0f3e2.

This pull request removes 23 and adds 59 tests. Note that renamed tests count towards both. 
metabrainz.supporter.views_test.SupportersViewsTestCase ‑ test_login
metabrainz.supporter.views_test.SupportersViewsTestCase ‑ test_logout
metabrainz.supporter.views_test.SupportersViewsTestCase ‑ test_musicbrainz
metabrainz.supporter.views_test.SupportersViewsTestCase ‑ test_musicbrainz_post
metabrainz.supporter.views_test.SupportersViewsTestCase ‑ test_signup
metabrainz.views_test.IndexViewsTestCase ‑ test_about
metabrainz.views_test.IndexViewsTestCase ‑ test_about_customers
metabrainz.views_test.IndexViewsTestCase ‑ test_bad_customers
metabrainz.views_test.IndexViewsTestCase ‑ test_code_of_conduct
metabrainz.views_test.IndexViewsTestCase ‑ test_contact
…

metabrainz.index.views_test.IndexViewsTestCase ‑ test_about
metabrainz.index.views_test.IndexViewsTestCase ‑ test_about_customers
metabrainz.index.views_test.IndexViewsTestCase ‑ test_bad_customers
metabrainz.index.views_test.IndexViewsTestCase ‑ test_code_of_conduct
metabrainz.index.views_test.IndexViewsTestCase ‑ test_contact
metabrainz.index.views_test.IndexViewsTestCase ‑ test_dataset_download
metabrainz.index.views_test.IndexViewsTestCase ‑ test_dataset_signup
metabrainz.index.views_test.IndexViewsTestCase ‑ test_datasets
metabrainz.index.views_test.IndexViewsTestCase ‑ test_derived_dumps
metabrainz.index.views_test.IndexViewsTestCase ‑ test_flask_debugtoolbar
…

♻️ This comment has been updated with latest results.

@amCap1712 amCap1712 marked this pull request as ready for review September 17, 2025 13:46
anshg1214 and others added 16 commits September 18, 2025 11:35
@anshg1214
feat: improve signup & login page
47006d6
@MonkeyDo
Refactor conditions modal
a1fa0f5 
It was duplicated and unused on two pages
@anshg1214
fix: forgot password page
79efa6b
@amCap1712
add moderation comments
cf285ce
@amCap1712
add manual email verification and more standard template
7f90a5b
@amCap1712
supporter fix
c138fee
@amCap1712
minor fixes
de01ceb
@MonkeyDo
Fix missing close button BS styles
e706522
@MonkeyDo
Hide password by default
34f51e3 
and add a button to show/hide the password
@MonkeyDo
Animate and reuse project logo pills
f98272f 
+ automatic formating
@MonkeyDo
Review conditions modal, add project logos
bb278aa
@MonkeyDo
Make password hide buttons accessible
ca86e75
@MonkeyDo
Use AuthCardPasswordInput for all password inputs
a99a25b
@MonkeyDo
Rework signup/login pages UI
c355e3b 
Fix form validation and UI hints, rework the UI to be more user-friendly, cleanup markup, make it more mobile friendly
@MonkeyDo
Block button on login page
7a381cf 
same as other pages, big call-to-action button as in the design files
@MonkeyDo
Block button on singup page
e1aedd2
@MonkeyDo
Copy link
Member

Reviewed and cleaned up the sign in and sign up pages (user and supporters, commercial and non-commercial)

Supporters
image
image

End users
image
image

@MonkeyDo
Add link to end-user singup from commercial signup pages\
71f5282 
We don't want end-users to create accounts directly on MeB.org, but it might just happen, so adding a link to the signup page they would be looking for.
@MonkeyDo
Add moderation_log to drop tables script
56e2aae 
Otherwise the entire test suite fails
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amCap1712 @MonkeyDo @anshg1214