Add notifications_enabled column, refactor digest-preference endpoint to notification-preference and some minor fixes #528
Conversation
…ication-preference, fix linting issues
|
@mayhem PR ready for review. |
|
I'll try and have a look tomorrow -- I'm "mostly" on vacation this week. |
|
Sorry, not feeling great right now. Hopefully tomorrow. |
No worries ! |
|
This PR looks good to me, but the bits about the PG extension need to have a quick review from @amCap1712 |
| db.run_sql_script_without_transaction(os.path.join(ADMIN_SQL_DIR, 'create_db.sql')) | ||
| click.echo('Done.') | ||
|
|
||
| db.init_db_engine(application.config["POSTGRES_ADMIN_MEB_URI"]) |
There was a problem hiding this comment.
This looks unneeded to me, the POSTGRES_ADMIN_URI config var does the same. Can you share the error you were facing?
There was a problem hiding this comment.
https://gist.github.com/fettuccinae/787cf9b7368cf9aa2efc977e000575d6
These were the logs I was getting when POSTGRES_ADMIN_URI was used to create extensions( I think it was creating extensions on the POSTGRES database instead on the METABRAINZ database)
Added a notifications_enabled column in user_preference table and related code in the endpoint, so that a user can set their notification preference, i.e if they want to receive email notifications immediately or in a digest.
They have 3 options now:
If notifications are disabled, they will be receiving only the important mails.
If notifications are enabled and digest is disabled, they will be receiving the mails(important and non important) immediately
If notifications are enabled and digest is enabled, they will be receiving the important mails directly and non-important mails in a digest.
Fixed linting issues (unused import and a semi colon)
Fixed the uuid extension missing bug by creating extensions in metabrainz db as the postgres user instead of creating them in the default postgres db.