Skip to content

Conversation

JordanEdward02
Copy link

Removing the ttip package is just a start at
removing jquery as a dependency. The browser
can handle titles itself to create popups so I
have just migrated them to use that instead.

We still have a couple of jquery uses in the code:

  • Keyboard shortcuts modal popup
  • Dropdown menu for the login and profile button

These are not trivial to remove unlike ttip so
I will not include them in this branch

Examples of the revised tooltips:

Screenshot from 2025-05-03 13-37-09
Screenshot from 2025-05-03 13-36-57

@JordanEdward02 JordanEdward02 marked this pull request as draft May 3, 2025 15:05
@oalders oalders force-pushed the jordanedward/update-bootstrap-and-remove-tooltip-package branch 2 times, most recently from 88917ae to 0e9a8ee Compare September 29, 2025 01:37
Removing the ttip package is just a start at
removing jquery as a dependency. The browser
can handle titles itself to create popups so I
have just migrated them to use that instead.

We still have a couple of jquery uses in the code:
 - quick command modal popup
 - Dropdown menu for the login and profile button

These are not trivial to remove unlike ttip so
I will not include them in this branch
@oalders oalders force-pushed the jordanedward/update-bootstrap-and-remove-tooltip-package branch from 0e9a8ee to 44eb1f6 Compare September 29, 2025 15:31
@haarg
Copy link
Member

haarg commented Sep 29, 2025

This updates the Bootstrap version, but doesn't do anything to adapt to the new version.

To start with, we currently include less and js files from Bootstrap, not the bundled version. None of the less files exist anymore, and the js files have all moved or are packaged differently.

There are also a significant number of breaking changes between bootstrap 3, 4, and 5, which haven't been addressed.

This is also removing the use of the Bootstrap tooltip component. That isn't tying us to jQuery at all. Bootstrap 5 still includes a tooltip component, which doesn't use jQuery. The things tying us to jQuery are the GitHub popup, table sorting, and the autocomplete dropdown. There are things in the js code using Bootstrap that need to call it via jQuery (like the ttip code being removed in this PR) but those would instead need to be adapted to Bootstrap 5's new calling conventions.

@oalders
Copy link
Member

oalders commented Sep 29, 2025

I think we could close this for the time being. I don't believe @JordanEdward02 has the bandwidth for it right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants