Skip to content

Add missing add_ function examples #192 #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add missing add_ function examples #192 #226

wants to merge 1 commit into from

Conversation

TobiasNx
Copy link
Contributor

@TobiasNx TobiasNx commented Jul 31, 2025 •
edited
Loading

See #192

This can be merged right away these examples are missing in the playground.

@TobiasNx TobiasNx requested review from blackwinter and Phu2 July 31, 2025 10:38
@blackwinter blackwinter mentioned this pull request Jul 31, 2025
Open
blackwinter
blackwinter approved these changes Jul 31, 2025
View reviewed changes
Copy link
Member

@blackwinter blackwinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The examples for add_array and add_hash don't show their respective behaviour with regard to the presence/absence of intermediate fields. I think it would make sense that add_* and set_* should match each other. But I'm fine either way.

@blackwinter blackwinter removed their assignment Jul 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blackwinter blackwinter blackwinter approved these changes

@Phu2 Phu2 Awaiting requested review from Phu2

Assignees

@Phu2 Phu2

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TobiasNx @blackwinter @Phu2