feat/0.3.0a#41
Open
metaforx wants to merge 143 commits into
Open
Conversation
Fix package installation path
- feat: updated unfold to version 0.66.0 - style: unified django-cms colors with unfold theme - fix: resolved django-cms sideframe and modal ui issues
- feat: update unfold to version 0.66.0 - style: unify django-cms colors with unfold theme - fix: resolve django-cms sideframe and modal UI issues
- Updated templates to include submit buttons inside forms. - Added modal close on save for better UX. - Enhanced request handling for language and redirection in PageAdmin.
docs: update docs Marc Widmer Moments ago fix: cms styling (sideframe, pagetree) Marc Widmer 18 minutes ago fix: remove versioning breadcrumbs template, unfold does not use breadcrumbs anymore Marc Widmer 37 minutes ago fix: djangocms-versioning changelist Marc Widmer 38 minutes ago fix: disable submit-row overwrite Marc Widmer 39 minutes ago fix: cms pagetree display with unfold sideframe Marc Widmer 39 minutes ago fix: improve action buttons in django pageContentAdmin Marc Widmer Today 15:23 feat: integrate custom change form for Page and PageContent admins Marc Widmer Today 14:40
…ndow (django cms) - Implemented `theme-receiver.js` to apply theme changes from parent to iframe. - Added `theme-sender.js` to propagate theme updates from iframe to parent. - Updated template tags and `README.md` for new theme synchronization scripts. - Enhanced theme switching for Django CMS when embedded in `Unfold Admin`.
feat: add inline-safe variant of PageSelectWidget to handle cloned rows
full width modal
fix cms modal breadcrumb style
…order remove border radius in text editor toolbar
Feat/django cms 5.0.8
Contributor
Reviewer's GuideMigrates the project from Poetry to uv for dependency management and CI, updates compatibility to django-unfold>=0.92 with the corresponding mixin refactor, and drops Python 3.11 support while bumping the package version to 0.3.0 alpha. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey - I've found 1 issue, and left some high level feedback:
- There are now two separate definitions of test dependencies (
[project.optional-dependencies].testand[dependency-groups].test) with overlapping but different contents; consider consolidating or clearly separating their purposes to avoid drift and confusion. - The CI workflow relies on
uv sync --locked, which requires a validuv.lock; ensure the lockfile is generated and committed (and kept in sync withpyproject.toml) so fresh clones can run the workflow without manual steps.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- There are now two separate definitions of test dependencies (`[project.optional-dependencies].test` and `[dependency-groups].test`) with overlapping but different contents; consider consolidating or clearly separating their purposes to avoid drift and confusion.
- The CI workflow relies on `uv sync --locked`, which requires a valid `uv.lock`; ensure the lockfile is generated and committed (and kept in sync with `pyproject.toml`) so fresh clones can run the workflow without manual steps.
## Individual Comments
### Comment 1
<location path="pyproject.toml" line_range="77-86" />
<code_context>
- "**/*.map",
- "**/.DS_Store",
- "**/__pycache__",
- "docs/**/*"
+ "unfold_extra/src/node_modules",
+ "unfold_extra/src/node_modules/**/*",
+ "unfold_extra/src/*.lock",
+ "unfold_extra/src/package-lock.json",
+ "**/*.map",
+ "**/.DS_Store",
+ "**/__pycache__",
+ "docs/**/*"
+,
]
</code_context>
<issue_to_address>
**issue (bug_risk):** The extra comma line makes the TOML array invalid and will likely break `hatch`/`uv` parsing.
In TOML, a trailing comma must come after the last element on the same line, not on its own line. As written, this adds a bare `,` entry, which is invalid TOML and will break parsing. It should look like:
```toml
exclude = [
"unfold_extra/src/node_modules",
"unfold_extra/src/node_modules/**/*",
"unfold_extra/src/*.lock",
"unfold_extra/src/package-lock.json",
"**/*.map",
"**/.DS_Store",
"**/__pycache__",
"docs/**/*",
]
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #35
Summary by Sourcery
Prepare 0.3.0 alpha release by migrating to uv-based dependency management, updating django-unfold integration, and dropping Python 3.11 support.
New Features:
Enhancements:
Build:
CI:
Chores: