Skip to content

fix: add inactive page title and message to form entry context - #26

Merged
metaforx merged 1 commit into
mainfrom
fix/missing-api-inactive-messages
May 4, 2026
Merged

fix: add inactive page title and message to form entry context#26
metaforx merged 1 commit into
mainfrom
fix/missing-api-inactive-messages

Conversation

@metaforx

@metaforx metaforx commented May 4, 2026

Copy link
Copy Markdown
Owner

Summary by Sourcery

New Features:

  • Expose inactive page title and message fields in the form fields API response.

@sourcery-ai

sourcery-ai Bot commented May 4, 2026

Copy link
Copy Markdown
Contributor
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Expose inactive form page title and message in the form entry context returned by the get_form_fields API so clients can render appropriate messaging when a form is inactive.

Sequence diagram for get_form_fields including inactive page messaging

sequenceDiagram
    participant Client
    participant API as GetFormFieldsAPI
    participant FormEntryModel

    Client->>API: GET /api/forms/{slug}/fields
    API->>FormEntryModel: load_form_entry(slug)
    FormEntryModel-->>API: form_entry
    API->>API: build context
    API->>API: set active_date_from, active_date_to
    API->>API: set success_page_title, success_page_message
    API->>API: set inactive_page_title, inactive_page_message
    API-->>Client: JSON context with fields and inactive messaging
Loading

Class diagram for updated form entry context structure

classDiagram
    class FormEntryContext {
        string slug
        datetime active_date_from
        datetime active_date_to
        string success_page_title
        string success_page_message
        string inactive_page_title
        string inactive_page_message
        string csrf_token
        list fields
    }

    class GetFormFieldsView {
        dict get_form_fields(request, slug)
    }

    GetFormFieldsView --> FormEntryContext : returns
Loading

File-Level Changes

Change Details Files
Expose inactive page title and message in the get_form_fields API response.
  • Extend the form_entry context dict in get_form_fields to include inactive_page_title with a safe default of an empty string when unset.
  • Extend the form_entry context dict in get_form_fields to include inactive_page_message with a safe default of an empty string when unset.
src/unfold_fobi/api/views.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@metaforx
metaforx merged commit 108b208 into main May 4, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant