🌱 Remove keepalived from BMO repository #2228
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit: - Removes all files and the workflow related to building keepalived - Ads swp files (vim temp files) to the gitignore These changes were needed because the community has decided that there is no reason to keep the keepalived files in BMO and they much better fit for the utility-images repository. Signed-off-by: Adam Rozman <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
size/L
|
/cc @lentzi90 @kashifest |
tuminoid
reviewed
Feb 2, 2025
| @@ -101,11 +101,10 @@ Once PR is merged following GitHub actions are triggered: | |||
| or a new patch release from the latest release branch, uncheck the box for | |||
| latest release. If it is a release candidate (RC) or a beta release, | |||
| tick pre-release box. | |||
| - GitHub jobs `build_bmo` and `build_keepalived` build release images with the | |||
| - GitHub job `build_bmo` build release images with the | |||
| release tag, and push them to Quay. Make sure the release tags are visible in | |||
| Quay tags pages: | |||
There was a problem hiding this comment.
Suggested change
| Quay tags pages: | |
| Quay tags page: |
| release tag, and push them to Quay. Make sure the release tags are visible in | ||
| Quay tags pages: | ||
| - [BMO](https://quay.io/repository/metal3-io/baremetal-operator?tab=tags) | ||
| - [keepalived](https://quay.io/repository/metal3-io/keepalived?tab=tags) | ||
| If the new release tag is not available for any of the images, check if the |
There was a problem hiding this comment.
Wording should be updated from IPAM or other single image repo.
metal3-io-bot
added
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
These changes were needed because the community has decided that there is no reason to keep the keepalived files in BMO and they much better fit for the utility-images repository.
Related issue: #2085