-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 E2E: Adjust Ironic kustomization patch #2308
🌱 E2E: Adjust Ironic kustomization patch #2308
Conversation
We have removed the IP address from the CA in the source manifests. This breaks the replacement because it was selecting ALL certificates. This commit changes it to only select the ironic-certificate. Signed-off-by: Lennart Jern <[email protected]>
/hold |
/test ? |
@lentzi90: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test metal3-e2e-clusterctl-upgrade-test-main |
The test has successfully deployed Ironic from the correct overlay:
This is the one that is pointed to the branch in metal3-io/baremetal-operator#2222 in the test commit to check that it works. |
The test was successful: https://jenkins.nordix.org/view/Metal3/job/metal3-e2e-clusterctl-upgrade-test-main/111/ |
2adfcdf
to
02eebf2
Compare
/test metal3-centos-e2e-integration-test-main |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kashifest The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
What this PR does / why we need it:
We have removed the IP address from the CA in the source manifests. This
breaks the replacement because it was selecting ALL certificates. This
commit changes it to only select the ironic-certificate.
See metal3-io/baremetal-operator#2222