Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 E2E: Adjust Ironic kustomization patch #2308

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

lentzi90
Copy link
Member

@lentzi90 lentzi90 commented Feb 5, 2025

What this PR does / why we need it:

We have removed the IP address from the CA in the source manifests. This
breaks the replacement because it was selecting ALL certificates. This
commit changes it to only select the ironic-certificate.

See metal3-io/baremetal-operator#2222

We have removed the IP address from the CA in the source manifests. This
breaks the replacement because it was selecting ALL certificates. This
commit changes it to only select the ironic-certificate.

Signed-off-by: Lennart Jern <[email protected]>
@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 5, 2025
@lentzi90
Copy link
Member Author

lentzi90 commented Feb 5, 2025

/hold
Until the test commit is removed and metal3-io/baremetal-operator#2222 is merged

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 5, 2025
@lentzi90
Copy link
Member Author

lentzi90 commented Feb 5, 2025

/test ?

@metal3-io-bot
Copy link
Contributor

@lentzi90: The following commands are available to trigger required jobs:

/test build
/test generate
/test gomod
/test manifestlint
/test markdownlint
/test metal3-centos-e2e-integration-test-main
/test metal3-ubuntu-e2e-integration-test-main
/test shellcheck
/test test
/test unit

The following commands are available to trigger optional jobs:

/test metal3-centos-e2e-basic-test-main
/test metal3-centos-e2e-feature-test-main-features
/test metal3-centos-e2e-feature-test-main-pivoting
/test metal3-centos-e2e-feature-test-main-remediation
/test metal3-centos-e2e-feature-test-main-scalability
/test metal3-e2e-1-29-1-30-upgrade-test-main
/test metal3-e2e-clusterctl-upgrade-test-main
/test metal3-ubuntu-e2e-basic-test-main
/test metal3-ubuntu-e2e-feature-test-main-features
/test metal3-ubuntu-e2e-feature-test-main-pivoting
/test metal3-ubuntu-e2e-feature-test-main-remediation

Use /test all to run the following jobs that were automatically triggered:

build
generate
gomod
manifestlint
unit

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@lentzi90
Copy link
Member Author

lentzi90 commented Feb 5, 2025

/test metal3-e2e-clusterctl-upgrade-test-main

@lentzi90
Copy link
Member Author

lentzi90 commented Feb 5, 2025

The test has successfully deployed Ironic from the correct overlay:

STEP: Installing Ironic from kustomization data/ironic-deployment/overlays/release-27.0 on the upgrade cluster

This is the one that is pointed to the branch in metal3-io/baremetal-operator#2222 in the test commit to check that it works.

@lentzi90
Copy link
Member Author

lentzi90 commented Feb 5, 2025

The test was successful: https://jenkins.nordix.org/view/Metal3/job/metal3-e2e-clusterctl-upgrade-test-main/111/
I will now remove the test commit

@lentzi90 lentzi90 force-pushed the lentzi90/ironic-ca-address branch from 2adfcdf to 02eebf2 Compare February 5, 2025 10:29
@lentzi90
Copy link
Member Author

lentzi90 commented Feb 5, 2025

/test metal3-centos-e2e-integration-test-main
/test metal3-ubuntu-e2e-integration-test-main

@adilGhaffarDev
Copy link
Member

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 5, 2025
Copy link
Member

@kashifest kashifest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 5, 2025
@lentzi90
Copy link
Member Author

lentzi90 commented Feb 5, 2025

/hold cancel

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 5, 2025
@metal3-io-bot metal3-io-bot merged commit 3dd2cb5 into metal3-io:main Feb 5, 2025
14 checks passed
@metal3-io-bot metal3-io-bot deleted the lentzi90/ironic-ca-address branch February 5, 2025 13:41
@metal3-io-bot metal3-io-bot added this to the CAPM3 - v1.10 milestone Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants