🌱 Use osv-scanner workflow file instead of local workflow #676
Conversation
metal3-io-bot
added
the
do-not-merge/work-in-progress
metal3-io-bot
added
the
size/XS
kashifest
force-pushed
the
fix/osv-scanner-kashif
branch
from
512d1ed to
e8bc6a4
Compare
|
@tuminoid please dont review it yet, this is WIP |
kashifest
force-pushed
the
fix/osv-scanner-kashif
branch
from
e8bc6a4 to
0f0f2ab
Compare
Sorry, was going thru a bunch of them, missed that note. |
AH no need to be sorry, I meant I will push changes quite a few times here and also it has some test code currently. So no need to waste your energy yet 😄 |
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
Signed-off-by: Kashif Khan <[email protected]>
kashifest
force-pushed
the
fix/osv-scanner-kashif
branch
from
0f0f2ab to
12b883a
Compare
metal3-io-bot
added
size/L
kashifest
changed the title
metal3-io-bot
removed
the
do-not-merge/work-in-progress
|
@tuminoid PTAL now |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tuminoid The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
approved
|
/override metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main |
|
/lgtm |
|
/override metal3-centos-e2e-integration-test-main |
|
@mquhuy: mquhuy unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override metal3-centos-e2e-integration-test-main |
|
@tuminoid: Overrode contexts on behalf of tuminoid: metal3-centos-e2e-integration-test-main, metal3-ubuntu-e2e-integration-test-main In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
the osv-scanner workflow currently is not producing any meaningful scan output. Manual check revealed it so perhaps not running properly. Changing the workflow it to use osv scanner's workflow (this is recommended way) instead of having own local workflow seems to have solved the issue. This PR updates the workflow accordingly.