Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 fix OWNERS_ALIASES #120

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Conversation

tuminoid
Copy link
Member

@tuminoid tuminoid commented Jan 17, 2025

I think the {} does not work here, let's just have empty list instead.

Ref: #114 (comment)
Alternatively, bot is being drunk...

@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 17, 2025
@tuminoid tuminoid changed the title fix OWNERS_ALIASES 🌱 fix OWNERS_ALIASES Jan 17, 2025
@tuminoid
Copy link
Member Author

Hmm, blunderbuss is not activating either.

@tuminoid
Copy link
Member Author

@elfosardo
Copy link
Member

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: elfosardo
Once this PR has been reviewed and has the lgtm label, please assign ironic-standalone-operator-maintainers for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tuminoid
Copy link
Member Author

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: elfosardo Once this PR has been reviewed and has the lgtm label, please assign ironic-standalone-operator-maintainers for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

Yeah, same issue for you, approval not accepted. I think we need to force merge this, or somehow otherwise debug what is wrong.

I think the {} does not work here, let's just have empty list instead.

Signed-off-by: Tuomo Tanskanen <[email protected]>
@tuminoid tuminoid force-pushed the tuomo/fix-owners-aliases branch from b943d67 to 25922ed Compare January 17, 2025 09:48
@tuminoid
Copy link
Member Author

Looking at the Prow code and test cases, I think the empty group is not acceptable. I think Prow should've labeled the promotion PR with "do-not-merged/invalid-owners-file", but since it was empty group in OWNERS_ALIASES, it missed it.

I'll try to patch it in Prow, but for now, I'll merge this manually.

@tuminoid tuminoid merged commit 095f60b into metal3-io:main Jan 17, 2025
11 of 12 checks passed
@tuminoid tuminoid deleted the tuomo/fix-owners-aliases branch January 17, 2025 10:07
@tuminoid
Copy link
Member Author

OK, it fixed the issue as seen here: #114 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants