-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 fix OWNERS_ALIASES #120
🌱 fix OWNERS_ALIASES #120
Conversation
Hmm, blunderbuss is not activating either. |
/approve |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: elfosardo The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Yeah, same issue for you, approval not accepted. I think we need to force merge this, or somehow otherwise debug what is wrong. |
I think the {} does not work here, let's just have empty list instead. Signed-off-by: Tuomo Tanskanen <[email protected]>
b943d67
to
25922ed
Compare
Looking at the Prow code and test cases, I think the empty group is not acceptable. I think Prow should've labeled the promotion PR with "do-not-merged/invalid-owners-file", but since it was empty group in OWNERS_ALIASES, it missed it. I'll try to patch it in Prow, but for now, I'll merge this manually. |
OK, it fixed the issue as seen here: #114 (comment) |
I think the {} does not work here, let's just have empty list instead.
Ref: #114 (comment)
Alternatively, bot is being drunk...