✨ Keepalived read-only file-system support #32

Rozzii · 2025-03-27T13:55:25Z

This PR:

Adds read only file system support for the keepalived container
Extend the README with keepalived related information

These changes were needed because:

The previous implementation was not compatible with running the container
with a read only root file system.

Related issue: metal3-io/ironic-image#613

P.S needs to be rebased after #27 is merged
/hold

Rozzii · 2025-03-27T13:55:47Z

/hold

Rozzii · 2025-03-28T11:48:42Z

/hold cancel

tuminoid

Two readability nits, otherwise lgtm.

keepalived/manage-keepalived.sh

tuminoid

/lgtm

lentzi90

Wondering about the "extra" vars, otherwise this looks good to me

keepalived/manage-keepalived.sh

README.md

This commit: - Adds read-only fie system support for the keepalived container - Extend the README with keepalived related information These changes were needed because: - The previous implementation was not compatible with running the container with a read only root file system. Signed-off-by: Adam Rozman <[email protected]>

tuminoid · 2025-06-16T12:54:45Z

/test ?

metal3-io-bot · 2025-06-16T12:54:49Z

@tuminoid: The following commands are available to trigger required jobs:

/test markdownlint

/test shellcheck

Use /test all to run all jobs.

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tuminoid

/approve

I created metal3-io/project-infra#1039 to remind us to add some e2e tests for this repo.

I've manually checked it does at least compile and run when caps are added. There shouldn't be any need for writing into filesystem.

tuminoid

/lgtm

lentzi90

/approve

metal3-io-bot · 2025-06-16T13:10:35Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90, tuminoid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [lentzi90]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Rozzii · 2025-06-16T13:12:22Z

/approve

I created metal3-io/project-infra#1039 to remind us to add some e2e tests for this repo.

I've manually checked it does at least compile and run when caps are added. There shouldn't be any need for writing into filesystem.

I was actually creating this:
I think e2e is overkill here, instead I would like to do this: #39

dtantsur · 2025-06-16T15:25:07Z

keepalived/manage-keepalived.sh

+KEEPALIVED_CONF="${KEEPALIVED_CONF_DIR}/keepalived.conf"
+KEEPALIVED_DATA_DIR="${CUSTOM_DATA_DIR}/keepalived"
+
+mkdir -p "${KEEPALIVED_CONF_DIR}" "${KEEPALIVED_DATA_DIR}"


This is broken without root

metal3-io-bot requested review from dtantsur and lentzi90 March 27, 2025 13:55

metal3-io-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 27, 2025

metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 27, 2025

Rozzii changed the title ~~✨ Keepalived read-only file-system support~~ WIP ✨ Keepalived read-only file-system support Mar 27, 2025

metal3-io-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 27, 2025

Rozzii force-pushed the keepalive_ro_fs branch from c4fcde3 to 7bb51e9 Compare March 28, 2025 11:48

metal3-io-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 28, 2025

metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 28, 2025

Rozzii changed the title ~~WIP ✨ Keepalived read-only file-system support~~ ✨ Keepalived read-only file-system support Mar 28, 2025

metal3-io-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 28, 2025

Rozzii force-pushed the keepalive_ro_fs branch from 7bb51e9 to 2c210fe Compare March 28, 2025 11:52

tuminoid reviewed Mar 28, 2025

View reviewed changes

keepalived/manage-keepalived.sh Show resolved Hide resolved

keepalived/manage-keepalived.sh Show resolved Hide resolved

Rozzii force-pushed the keepalive_ro_fs branch from 2c210fe to 107c3c6 Compare March 28, 2025 12:38

Rozzii requested a review from tuminoid March 28, 2025 14:47

tuminoid reviewed Mar 28, 2025

View reviewed changes

metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 28, 2025

lentzi90 reviewed Mar 31, 2025

View reviewed changes

keepalived/manage-keepalived.sh Show resolved Hide resolved

README.md Outdated Show resolved Hide resolved

README.md Outdated Show resolved Hide resolved

lentzi90 reviewed Mar 31, 2025

View reviewed changes

README.md Outdated Show resolved Hide resolved

README.md Outdated Show resolved Hide resolved

Rozzii force-pushed the keepalive_ro_fs branch from 107c3c6 to b1cdbed Compare June 16, 2025 11:23

metal3-io-bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 16, 2025

Rozzii requested review from lentzi90 and tuminoid June 16, 2025 11:24

tuminoid reviewed Jun 16, 2025

View reviewed changes

metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 16, 2025

lentzi90 reviewed Jun 16, 2025

View reviewed changes

metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 16, 2025

metal3-io-bot merged commit a98b876 into metal3-io:main Jun 16, 2025
6 checks passed

metal3-io-bot deleted the keepalive_ro_fs branch June 16, 2025 13:12

Rozzii mentioned this pull request Jun 16, 2025

Support utility images repo for running e2e keywords metal3-io/project-infra#1039

Open

dtantsur reviewed Jun 16, 2025

View reviewed changes

dtantsur mentioned this pull request Jun 16, 2025

✨ Add a new release workflow and documentation metal3-io/ironic-standalone-operator#211

Merged

✨ Keepalived read-only file-system support #32

✨ Keepalived read-only file-system support #32

Uh oh!

Conversation

Rozzii commented Mar 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Rozzii commented Mar 27, 2025

Uh oh!

Rozzii commented Mar 28, 2025

Uh oh!

tuminoid left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

tuminoid left a comment

Choose a reason for hiding this comment

Uh oh!

lentzi90 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tuminoid commented Jun 16, 2025

Uh oh!

metal3-io-bot commented Jun 16, 2025

Uh oh!

tuminoid left a comment

Choose a reason for hiding this comment

Uh oh!

tuminoid left a comment

Choose a reason for hiding this comment

Uh oh!

lentzi90 left a comment

Choose a reason for hiding this comment

Uh oh!

metal3-io-bot commented Jun 16, 2025

Uh oh!

Uh oh!

Rozzii commented Jun 16, 2025

Uh oh!

dtantsur Jun 16, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Rozzii commented Mar 27, 2025 •

edited

Loading