Skip to content

✨ add keepalived image build workflow #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 28, 2025
Merged

✨ add keepalived image build workflow #33

merged 1 commit into from
Mar 28, 2025

Conversation

@Rozzii
Copy link
Member

@Rozzii Rozzii commented Mar 27, 2025

This PR:

  • Adds keepalived container image build workflow

This commit is needed in order to be able to build the newly introduced keepalived container.

This needs to get merged right after #27

@Rozzii
add keepalived image build workflow
21422a3 
This commit:
 - Adds keepalived container image build workflow

This commit is needed in order to be able to build the newly introduced
keepalived container.

Signed-off-by: Adam Rozman <[email protected]>
@Rozzii
Copy link
Member Author

Rozzii commented Mar 27, 2025

/hold

@metal3-io-bot metal3-io-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Mar 27, 2025
tuminoid
tuminoid reviewed Mar 27, 2025
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 27, 2025
kashifest
kashifest reviewed Mar 28, 2025
View reviewed changes
Copy link
Member

@kashifest kashifest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

lentzi90
lentzi90 reviewed Mar 28, 2025
View reviewed changes
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Collaborator

metal3-io-bot commented Mar 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 28, 2025
@Rozzii
Copy link
Member Author

Rozzii commented Mar 28, 2025

/hold cancel

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 28, 2025
@metal3-io-bot metal3-io-bot merged commit ba15f97 into metal3-io:main Mar 28, 2025
4 checks passed
@metal3-io-bot metal3-io-bot deleted the keepalived_build_action branch March 28, 2025 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tuminoid tuminoid tuminoid left review comments

@kashifest kashifest kashifest left review comments

+1 more reviewer

@lentzi90 lentzi90 lentzi90 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Rozzii @metal3-io-bot @tuminoid @lentzi90 @kashifest